Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1133: fix deploying too many dataExtensions blocked by server error #1178

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jan 17, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

This fixes the "Some part of your SQL statement is nested too deeply" server error.

I tested by trying to deploy 1000 dataExtensions at once. didn't work with the old approach. did work with the new IN approach

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

"Some part of your SQL statement is nested too deeply"
@JoernBerkefeld JoernBerkefeld added this to the 6.0.2 milestone Jan 17, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 17, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Jan 17, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Coverage Report

Commit:682a074
Base: develop@1ae108a

Type Base This PR
Total Statements Coverage  64.23%  64.21%  (-0.02%)
Total Branches Coverage  67.13%  67.15%  (+0.02%)
Total Functions Coverage  73.48%  73.48%  (+0%)
Total Lines Coverage  64.23%  64.21%  (-0.02%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/DataExtension.js  79.15%  65.8%  94.11%  79.15%

@JoernBerkefeld JoernBerkefeld merged commit 5f06796 into develop Jan 17, 2024
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/1133-error-when-deploying-dataextension-sql-statement-nested-too-deeply branch January 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/dataExtension COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] error when deploying dataExtension "SQL statement nested too deeply"
1 participant