Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/62 resolve sendClassification & senderProfile in triggeredSend, emailSend and journey #1268

Merged
merged 33 commits into from
May 15, 2024
Merged

Feature/62 resolve sendClassification & senderProfile in triggeredSend, emailSend and journey #1268

merged 33 commits into from
May 15, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Apr 17, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

todo: add proper tests for the 3 journey types (transactional, quicksend, multi-step)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone Apr 17, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 17, 2024
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Apr 17, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Apr 17, 2024 that may be closed by this pull request
[FEATURE] resolve sendClassification & senderProfile in triggeredSend, emailSend and journey #62
Closed
4 tasks
@JoernBerkefeld
#62: improve warnings
bb1e726
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
7181eba 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
5dde228 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
8641d83 
…resolve-sendclassification-+-senderprofile-csclsroz-315

# Conflicts:
#	lib/metadataTypes/Event.js
@JoernBerkefeld
#62: add test for retrieve quicksend journey
de04373
@JoernBerkefeld
#62: add message priority mapping
b58668a
@JoernBerkefeld
#62: added test for basic multi-step journey
33b0200
@JoernBerkefeld
#62: added decision split to multistep journey test
3936c08
@JoernBerkefeld
#62: added retrieve test for transactional email journey
5e4e99b
@JoernBerkefeld
#62: add journey tests for retrieve without key and for retrieve with id
a82ed1d
@JoernBerkefeld
#62: fix journey deletion test
8f34313
@JoernBerkefeld
#62: fix templating test for journeys
336bc38
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024 •
edited
Loading

Coverage Report

Commit:de374c7
Base: develop@961ae8e

Type Base This PR
Total Statements Coverage  66.42%  67.24%  (+0.82%)
Total Branches Coverage  66.56%  66.61%  (+0.05%)
Total Functions Coverage  76.88%  77.54%  (+0.66%)
Total Lines Coverage  66.42%  67.24%  (+0.82%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
3394066 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
5471525 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
#62: convert triggeredSend Priority (number) to c__priority (enum)
cbc1ad9
@JoernBerkefeld
#62: fixed test that confirms you cannot use changeKeyValue/changeKey…
861877f 
…Field on journey
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
da527a5 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
269ccdd 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
#0: allow retrieving automations by objectid
f6d212d
@JoernBerkefeld
#0: retrieve & delete asset by id/name/key
719e763
@JoernBerkefeld
#0: regression fix for f6d212d
65f927f
@JoernBerkefeld
Merge branch 'develop' into feature/62-triggeredsendemailsend-do-not-…
13a4d1d 
…resolve-sendclassification-+-senderprofile-csclsroz-315
@JoernBerkefeld
#62: reworked event processing based on SalesforceObjectTriggerV2
bffeecb 
might need future changes for the other 3 types
@JoernBerkefeld
#62: remove redundant triggeredSend info
de374c7
@JoernBerkefeld JoernBerkefeld merged commit 2e9b905 into develop May 15, 2024
7 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/62-triggeredsendemailsend-do-not-resolve-sendclassification-+-senderprofile-csclsroz-315 branch May 15, 2024 13:42
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/emailSend COMPONENT c/journey COMPONENT c/triggeredSend COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] resolve sendClassification & senderProfile in triggeredSend, emailSend and journey
1 participant
@JoernBerkefeld