Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/1306: remove empty entry from explainTypes json response #1309

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 8, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 8, 2024
@github-actions github-actions bot added the bug Something isn't working label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Coverage Report

Commit:9169c1d
Base: develop@fe5b975

Type Base This PR
Total Statements Coverage  66.47%  66.48%  (+0.01%)
Total Branches Coverage  66.75%  66.78%  (+0.03%)
Total Functions Coverage  76.8%  76.8%  (+0%)
Total Lines Coverage  66.47%  66.48%  (+0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/cli.js  38.9%  78.04%  25%  38.9%

@JoernBerkefeld JoernBerkefeld merged commit aa4bc9a into develop May 8, 2024
5 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1306-filter-empty-shell-in-explaintypes branch May 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant