Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/1350: ensure compatibility & testing with node 19 and node 20 #1351

Merged
merged 6 commits into from
May 31, 2024
Merged

bugfix/1350: ensure compatibility & testing with node 19 and node 20 #1351

merged 6 commits into from
May 31, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 29, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.0.0 milestone May 29, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 29, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label May 29, 2024
@JoernBerkefeld JoernBerkefeld changed the title task/1350: switch from fixed node-version to whatever is set in package.json engines.node bugfix/1350: ensure compatibility & testing with node 19 and node 20 May 29, 2024
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/Testing COMPONENT labels May 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Coverage Report

Commit:c8f40d0
Base: develop@074b833

Type Base This PR
Total Statements Coverage  67.84%  67.88%  (+0.04%)
Total Branches Coverage  67.11%  67.24%  (+0.13%)
Total Functions Coverage  79.18%  79.21%  (+0.03%)
Total Lines Coverage  67.84%  67.88%  (+0.04%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld linked an issue May 31, 2024 that may be closed by this pull request
[BUG] upgrade workflows to use node 18.18.2 and ensure testing with node 19 and 20 #1350
Closed
@JoernBerkefeld JoernBerkefeld merged commit 8d7bd42 into develop May 31, 2024
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1350-upgrade-workflows-to-use-node-18182 branch May 31, 2024 10:12
@github-actions github-actions bot mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/Testing COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] upgrade workflows to use node 18.18.2 and ensure testing with node 19 and 20
1 participant
@JoernBerkefeld