Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.1 - hotfix for mcdev upgrade #1381

Merged
merged 14 commits into from
Jun 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ body:
label: Version
description: What version of our software are you running? (mcdev --version)
options:
- 7.0.1
- 7.0.0
- 6.0.2
- 6.0.1
Expand Down
15 changes: 5 additions & 10 deletions @types/lib/metadataTypes/TransactionalMessage.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ declare namespace TransactionalMessage {
isUpdateable: boolean;
retrieving: boolean;
template: boolean;
};
}; /**
* TransactionalMessage MetadataType
*
* @augments MetadataType
*/
description: {
isCreateable: boolean;
isUpdateable: boolean;
Expand All @@ -120,15 +124,6 @@ declare namespace TransactionalMessage {
requestId: {
isCreateable: boolean;
isUpdateable: boolean;
/**
* Retrieves Metadata
*
* @param {string} [retrieveDir] Directory where retrieved metadata directory will be saved
* @param {void | string[]} [_] unused parameter
* @param {void | string[]} [__] unused parameter
* @param {string} [key] customer key of single item to retrieve
* @returns {Promise.<MetadataTypeMapObj>} Promise of metadata
*/
retrieving: boolean;
template: boolean;
};
Expand Down
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/TransactionalMessage.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/util/cli.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default {
restPageSize: 100,
type: '',
typeDescription: 'here as a placeholder to have auto completion',
typeRetrieveByDefault: true,
typeRetrieveByDefault: false,
typeName: '',
fields: {
name: {
Expand Down
12 changes: 10 additions & 2 deletions lib/util/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,10 @@ const Cli = {
}
const flattenedDefinitions = [];
for (const el in MetadataDefinitions) {
if (MetadataDefinitions[el].type === '') {
// dont offer wrapper types like TransactionalMessage which don't have a value in "type"
continue;
}
// if subtypes on metadata (eg. Assets) then add each nested subtype
if (
MetadataDefinitions[el].subTypes &&
Expand Down Expand Up @@ -618,8 +622,8 @@ const Cli = {

for (const apiName of apiNameArr) {
const details = MetadataDefinitions[apiName];
if (!details.type) {
// we created the main type transactional message but don't want to show it here
if (details.type === '') {
// skip wrapper types like TransactionalMessage which don't have a value in "type"
continue;
}
const supportCheckClass = apiName.startsWith('transactional')
Expand Down Expand Up @@ -662,6 +666,10 @@ const Cli = {

const typeChoices = [];
for (const el in MetadataDefinitions) {
if (MetadataDefinitions[el].type === '') {
// skip wrapper types like TransactionalMessage which don't have a value in "type"
continue;
}
if (MetadataDefinitions[el].subTypes && MetadataDefinitions[el].extendedSubTypes) {
// used for assets to show whats available by default
typeChoices.push({
Expand Down
Loading
Loading