Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1541 fix folder-error regression during asset deployments #1543

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 2, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld self-assigned this Aug 2, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 2, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.3 milestone Aug 2, 2024
@JoernBerkefeld JoernBerkefeld added c/asset COMPONENT and removed bug Something isn't working labels Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Coverage Report

Commit:ecec9a6
Base: develop@b49a819

Type Base This PR
Total Statements Coverage  70.6%  70.59%  (-0.01%)
Total Branches Coverage  69.77%  69.77%  (+0%)
Total Functions Coverage  82.72%  82.72%  (+0%)
Total Lines Coverage  70.6%  70.59%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  78.03%  67.53%  89.36%  78.03%

@JoernBerkefeld JoernBerkefeld added the bug Something isn't working label Aug 2, 2024
@JoernBerkefeld JoernBerkefeld merged commit 9754a89 into develop Aug 2, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1541-regression-deployment-error-skipping-asset-x-y-dependent-folder-could-not-be-found-because-r__folder_path-is-not-set branch August 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
1 participant