task/1574 allow overriding prettier parser in config

[BlakeTnr]

PR details

What changes did you make? (Give an overview)

• closes [BUG] Prettier parser overrides not working #1574

Further details (optional)

...

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [n/a ] test scripts updated
• [n/a ] Wiki updated (if applicable)

[JoernBerkefeld]

given that test cases all check out I'll merge your PR.
have you considered that the prettier config is loaded once per metadata type during retrieval?
search the code for File.initPrettier() calls:

sooo, it might just not have the big impact that you expect

[BlakeTnr]

given that test cases all check out I'll merge your PR. have you considered that the prettier config is loaded once per metadata type during retrieval? search the code for File.initPrettier() calls:

sooo, it might just not have the big impact that you expect

I have not considered this, I will look into this tomorrow. I know that this just worked for our use case because we only needed to override for an entire metadata type.

[BlakeTnr]

given that test cases all check out I'll merge your PR. have you considered that the prettier config is loaded once per metadata type during retrieval? search the code for File.initPrettier() calls:

sooo, it might just not have the big impact that you expect

Yeah just tested it, you're right. A config like this does not work.

"overrides": [
        {
            "files": "*.html",
            "excludeFiles": "**/e0b2a5fa-157d-40b9-8333-1ab6c8876549/*.html",
            "options": { "parser": "babel" }
        },
        {
            "files": "**/e0b2a5fa-157d-40b9-8333-1ab6c8876549/*.html",
            "options": { "parser": "html" }
        }
    ]

[JoernBerkefeld]

From my POV that's not bad though as you would expect that formatting is the same everywhere in a project folder