Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/1570 salesforce triggered journeys cannot be published after deploy #1604

Merged
merged 29 commits into from
Aug 28, 2024
Merged

bug/1570 salesforce triggered journeys cannot be published after deploy #1604

merged 29 commits into from
Aug 28, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 26, 2024 •
edited
Loading

…efore deploy and after retrieve# PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld
#1570: check if triggering SF objects and their fields are existing b…
e302d74 
…efore deploy and after retrieve
@JoernBerkefeld
#1570: cleanup & jsdocs
4bccdf4
@JoernBerkefeld
#1570: checks for eventDataSummary and passThroughArgument
fbd4f38
@JoernBerkefeld
#1570: jsdocs
5d53aa6
@JoernBerkefeld
#1570: check contactKey and improve how passThroughArgument is tested
e6ace4e
@JoernBerkefeld
#1570: code comments
d15972e
@JoernBerkefeld
Merge branch 'develop' into bug/1570-salesforce-triggered-journeys-ca…
e0a71a9 
…nnot-be-published-after-deploy
@JoernBerkefeld
Merge branch 'develop' into bug/1570-salesforce-triggered-journeys-ca…
a9311a0 
…nnot-be-published-after-deploy
@JoernBerkefeld
#1570: disable SF fields check until we have documentation for using …
3cabe0c 
…the the proper API
@JoernBerkefeld
#1570: add test for required eventDefinition configuration arguments …
46f8d07 
…to event + journey
@JoernBerkefeld
Revert "#1570: disable SF fields check until we have documentation fo…
78e7a75 
…r using the the proper API"

This reverts commit 3cabe0c.
@JoernBerkefeld
#1570: improve how missing default fields are checked for
d4296cd
@JoernBerkefeld
#1570: handle fake "Common" object more efficiently
1c5266c
@JoernBerkefeld
#1570: fix test for contactKey
d4aff4d
@JoernBerkefeld
#1570: disable warnings for missing tests as they are not currently r…
331d307 
…eliable due to the bad API
@JoernBerkefeld
#1570: mark next steps
0fd8b40
@JoernBerkefeld
#1570: fix test for contactKey
5bb443d
@JoernBerkefeld
#1570: improve contactKey error message for Common vs Contact
6b7ea8c
@JoernBerkefeld
#1570: cleanup
adfbd3b
@JoernBerkefeld
#1570: disable beautyAmp for *.html files again
0e7a251
@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Aug 26, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.2.1 milestone Aug 26, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 26, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Aug 26, 2024 that may be closed by this pull request
[BUG] salesforce triggered journeys cannot be published after deploy #1570
Closed
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Coverage Report

Commit:1b700c3
Base: develop@8620ad0

Type Base This PR
Total Statements Coverage  71%  70.25%  (-0.75%)
Total Branches Coverage  69.66%  69.01%  (-0.65%)
Total Functions Coverage  82.4%  82.21%  (-0.19%)
Total Lines Coverage  71%  70.25%  (-0.75%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit b9d877a into develop Aug 28, 2024
10 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1570-salesforce-triggered-journeys-cannot-be-published-after-deploy branch August 28, 2024 20:10
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

[BUG] salesforce triggered journeys cannot be published after deploy
1 participant
@JoernBerkefeld