Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/1657 fix eventDataSummary not getting saved correctly #1658

Merged
merged 2 commits into from
Sep 2, 2024
Merged

bug/1657 fix eventDataSummary not getting saved correctly #1658

merged 2 commits into from
Sep 2, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Sep 2, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.0 milestone Sep 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 2, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Sep 2, 2024 that may be closed by this pull request
[BUG] eventSummary not deployed correctly as string #1657
Closed
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Sep 2, 2024
Base automatically changed from bug/1644-deploy-of-dataextension-fails-with-error-string-or-binary-data-would-be-truncated-the-statement-has-been-terminated to develop September 2, 2024 22:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Coverage Report

Commit:b5d8cec
Base: develop@1d7fe93

Type Base This PR
Total Statements Coverage  69.92%  69.91%  (-0.01%)
Total Branches Coverage  68.7%  68.7%  (+0%)
Total Functions Coverage  81.99%  81.99%  (+0%)
Total Lines Coverage  69.92%  69.91%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Event.js  53.37%  37.31%  82.35%  53.37%

@JoernBerkefeld JoernBerkefeld merged commit 39e440f into develop Sep 2, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1657-eventsummary-not-deployed-correctly-as-string branch September 2, 2024 22:13
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

[BUG] eventSummary not deployed correctly as string
1 participant
@JoernBerkefeld