Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1676 fix graceful handling of "key not found" error for journey and event #1677

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 5, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Sep 5, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.1 milestone Sep 5, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 5, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Coverage Report

Commit:04754c8
Base: develop@41a9454

Type Base This PR
Total Statements Coverage  69.83%  69.83%  (+0%)
Total Branches Coverage  68.71%  68.71%  (+0%)
Total Functions Coverage  81.55%  81.55%  (+0%)
Total Lines Coverage  69.83%  69.83%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Event.js  54.01%  37.31%  70%  54.01%
lib/metadataTypes/Journey.js  58.73%  60.91%  75%  58.73%

@JoernBerkefeld JoernBerkefeld merged commit 0dbca10 into develop Sep 5, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1676-trying-to-retrieve-a-non-existing-event-key-will-break-following-retrieve-by-key-events branch September 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] trying to retrieve a non-existing event key will break following retrieve-by-key events
1 participant