Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1690 show info how to fix config issues found by VSCE #1696

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Bug/1690 show info how to fix config issues found by VSCE #1696

merged 2 commits into from
Sep 11, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 11, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.4.1 milestone Sep 11, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 11, 2024
@JoernBerkefeld JoernBerkefeld added the e/IDE EPIC label Sep 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 11, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Sep 11, 2024 that may be closed by this pull request
[BUG] show info how to run mcdev upgrade when config issues are found but executed via vsce / with skipInteraction on #1690
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Coverage Report

Commit:3163534
Base: develop@9076243

Type Base This PR
Total Statements Coverage  69.82%  69.82%  (+0%)
Total Branches Coverage  68.7%  68.7%  (+0%)
Total Functions Coverage  81.55%  81.55%  (+0%)
Total Lines Coverage  69.82%  69.82%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/config.js  55.66%  36.84%  100%  55.66%

@JoernBerkefeld JoernBerkefeld merged commit 243f263 into develop Sep 11, 2024
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1690-show-info-how-to-run-mcdev-upgrade-when-config-issues-are-found-but-executed-via-vsce-with-skipinteraction-on branch September 11, 2024 13:54
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Closed
@JoernBerkefeld JoernBerkefeld added the vsce VSCode extension label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/IDE EPIC vsce VSCode extension
Projects
None yet
Milestone
7.4.1
1 participant
@JoernBerkefeld