Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/1806 fix cdp's handoff of source-market to buildTemplate #1821

Merged
merged 1 commit into from
Nov 2, 2024
Merged

bug/1806 fix cdp's handoff of source-market to buildTemplate #1821

merged 1 commit into from
Nov 2, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 2, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 2, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024 •
edited
Loading

Coverage Report

Commit:30ff95d
Base: develop@88af279

Type Base This PR
Total Statements Coverage  69.78%  69.75%  (-0.03%)
Total Branches Coverage  68.44%  68.44%  (+0%)
Total Functions Coverage  81.59%  81.59%  (+0%)
Total Lines Coverage  69.78%  69.75%  (-0.03%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/devops.js  14.68%  100%  25%  14.68%

@JoernBerkefeld JoernBerkefeld force-pushed the bug/1806-executing-mcdev-cdp-results-in-market-configuration-errors branch from 36ce548 to 30ff95d Compare November 2, 2024 17:12
@JoernBerkefeld JoernBerkefeld changed the title bug/1805 fix cdp's handoff of source-market to buildTemplate bug/1806 fix cdp's handoff of source-market to buildTemplate Nov 2, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Nov 2, 2024 that may be closed by this pull request
[BUG] Executing mcdev cdp results in market configuration errors #1806
Closed
2 tasks
@JoernBerkefeld JoernBerkefeld merged commit 82d7dc5 into develop Nov 2, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1806-executing-mcdev-cdp-results-in-market-configuration-errors branch November 2, 2024 17:14
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/DevOps EPIC
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

[BUG] Executing mcdev cdp results in market configuration errors
1 participant
@JoernBerkefeld