Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/1800 improve upsert & matchName errors #1823

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 4, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 4, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 4, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Nov 4, 2024
@JoernBerkefeld JoernBerkefeld added c/asset COMPONENT c/dataExtension COMPONENT chore Jira issue-type "Task" and removed chore Jira issue-type "Task" labels Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Coverage Report

Commit:cfa3e0a
Base: develop@ea6b7fc

Type Base This PR
Total Statements Coverage  69.75%  69.76%  (+0.01%)
Total Branches Coverage  68.46%  68.4%  (-0.06%)
Total Functions Coverage  81.59%  81.59%  (+0%)
Total Lines Coverage  69.75%  69.76%  (+0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  77.01%  67.51%  87.75%  77.01%
lib/metadataTypes/DataExtension.js  78.92%  69.14%  94.44%  78.92%
lib/metadataTypes/MetadataType.js  82.87%  79.56%  76.54%  82.87%

@JoernBerkefeld JoernBerkefeld merged commit 046121e into develop Nov 4, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1800-errors-for-deploying-with-matchname-should-contain-more-details branch November 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/asset COMPONENT c/dataExtension COMPONENT chore Jira issue-type "Task" e/DevOps EPIC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] errors for deploying with --matchName should contain more details
1 participant