Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/37 add support to update/create automation wait activities #1829

Merged
merged 8 commits into from
Nov 7, 2024
Merged

feature/37 add support to update/create automation wait activities #1829

merged 8 commits into from
Nov 7, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 4, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/waitActivity COMPONENT label Nov 4, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 4, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 4, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Nov 4, 2024 that may be closed by this pull request
Add support for automation-activity 'Wait' / CSCLSROZ-233 #37
Closed
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Coverage Report

Commit:3597bc0
Base: develop@feecb96

Type Base This PR
Total Statements Coverage  69.82%  69.85%  (+0.03%)
Total Branches Coverage  68.53%  68.84%  (+0.31%)
Total Functions Coverage  81.59%  81.62%  (+0.03%)
Total Lines Coverage  69.82%  69.85%  (+0.03%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Automation.js  80.54%  67.98%  94.44%  80.54%
lib/util/replaceContentBlockReference.js  96.5%  91.48%  100%  96.5%

@JoernBerkefeld
#37: add test for documentation of wait activity
0d70ec0
@JoernBerkefeld
#37: ensure 24hrs format is used in json/md
afba6eb
@JoernBerkefeld
#37: improve code comments
dc9baf5
@JoernBerkefeld
Merge remote-tracking branch 'origin/develop' into feature/37-add-sup…
3597bc0 
…port-for-automation-activity-wait-csclsroz-233

# Conflicts:
#	@types/lib/metadataTypes/Automation.d.ts.map
#	@types/lib/util/validations.d.ts.map
@JoernBerkefeld JoernBerkefeld merged commit 18af5d8 into develop Nov 7, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/37-add-support-for-automation-activity-wait-csclsroz-233 branch November 7, 2024 22:27
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Closed
@JoernBerkefeld JoernBerkefeld mentioned this pull request Nov 8, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/waitActivity COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

Add support for automation-activity 'Wait' / CSCLSROZ-233
1 participant
@JoernBerkefeld