Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/1839 limit noRootFolder validation rule to types other than cloudpa… #1843

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Nov 7, 2024

…ges, lists, automations, attributeSets

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.4.5 milestone Nov 7, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 7, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 7, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Nov 7, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Nov 7, 2024

Coverage Report

Commit:fbb2afd
Base: develop@bf124ba

Type Base This PR
Total Statements Coverage  69.82%  69.82%  (+0%)
Total Branches Coverage  68.49%  68.56%  (+0.07%)
Total Functions Coverage  81.59%  81.59%  (+0%)
Total Lines Coverage  69.82%  69.82%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/validations.js  71.68%  71.42%  75%  71.68%

@JoernBerkefeld JoernBerkefeld merged commit feecb96 into develop Nov 7, 2024
10 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1839-validation-rule-norootfolder-triggered-for-types-that-dont-make-sense branch November 7, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validationRule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] validation rule noRootFolder triggered for types that dont make sense
1 participant