Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/2138 allow filtering what metadata types will be looked at by createDeltaPkg #2141

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 4, 2025

…eDeltaPkg

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (TODO)

@JoernBerkefeld JoernBerkefeld added this to the 7.8.0 milestone Mar 4, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 4, 2025
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

Coverage Report

Commit:ab13225
Base: develop@06a7053

Type Base This PR
Total Statements Coverage  71.37%  71.36%  (-0.01%)
Total Branches Coverage  70.91%  70.93%  (+0.02%)
Total Functions Coverage  84.26%  84.26%  (+0%)
Total Lines Coverage  71.37%  71.36%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/config.js  54.21%  36.58%  100%  54.21%
lib/util/devops.js  15.56%  100%  25%  15.56%
lib/util/util.js  87.58%  77.99%  95.74%  87.58%

@JoernBerkefeld JoernBerkefeld requested a review from Copilot March 4, 2025 12:26
@JoernBerkefeld JoernBerkefeld changed the title feature/2138 allow filtering what metadata types will be looked at by creat… feature/2138 allow filtering what metadata types will be looked at by createDeltaPkg Mar 4, 2025
@JoernBerkefeld JoernBerkefeld merged commit 9765c25 into develop Mar 4, 2025
15 checks passed
@JoernBerkefeld JoernBerkefeld deleted the feature/2138-allow-filtering-what-types-are-allowed-to-be-recognized-by-createdeltapkg branch March 4, 2025 12:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new property "typeCdpByDefault" to various metadata type definitions to support filtering metadata types for CDP usage. The changes update multiple definition files by setting "typeCdpByDefault" to either true or false based on the appropriate metadata type.

Reviewed Changes

File Description
lib/metadataTypes/definitions/Asset.definition.js Added "typeCdpByDefault" flag set to true for asset metadata.
lib/metadataTypes/definitions/Automation.definition.js Added "typeCdpByDefault" flag set to true for automation metadata.
lib/metadataTypes/definitions/DataExtension.definition.js Added "typeCdpByDefault" flag set to true for data extension metadata.
lib/metadataTypes/definitions/EmailSend.definition.js Added "typeCdpByDefault" flag set to true for email send definition.
lib/metadataTypes/definitions/DomainVerification.definition.js Added "typeCdpByDefault" flag set to false for domain verification metadata.
lib/metadataTypes/definitions/Event.definition.js Added "typeCdpByDefault" flag set to true for event metadata.
lib/metadataTypes/definitions/AttributeSet.definition.js Added "typeCdpByDefault" flag set to false for attribute set metadata.
lib/metadataTypes/definitions/Discovery.definition.js Added "typeCdpByDefault" flag set to false for API discovery metadata.
lib/metadataTypes/definitions/FileTransfer.definition.js Added "typeCdpByDefault" flag set to true for file transfer metadata.
lib/metadataTypes/definitions/DataExtract.definition.js Added "typeCdpByDefault" flag set to true for data extract metadata.
lib/metadataTypes/definitions/DeliveryProfile.definition.js Added "typeCdpByDefault" flag set to false for delivery profile metadata.
lib/metadataTypes/definitions/AttributeGroup.definition.js Added "typeCdpByDefault" flag set to false for attribute group metadata.
lib/metadataTypes/definitions/FileLocation.definition.js Added "typeCdpByDefault" flag set to false for file location metadata.
lib/metadataTypes/definitions/Campaign.definition.js Added "typeCdpByDefault" flag set to false for campaign metadata.
lib/metadataTypes/definitions/DataExtractType.definition.js Added "typeCdpByDefault" flag set to false for data extract type metadata.
lib/metadataTypes/definitions/DataExtensionField.definition.js Added "typeCdpByDefault" flag set to false for data extension field metadata.
lib/metadataTypes/definitions/DataExtensionTemplate.definition.js Added "typeCdpByDefault" flag set to false for data extension template metadata.
lib/metadataTypes/definitions/Email.definition.js Added "typeCdpByDefault" flag set to false for classic email metadata.
lib/metadataTypes/definitions/ContentArea.definition.js Added "typeCdpByDefault" flag set to false for classic content area metadata.

Copilot reviewed 168 out of 168 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e/DevOps EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] allow filtering what types are allowed to be recognized by createDeltaPkg
1 participant