-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/554 auto generate markets and marketlist upon mcdev init + fixes #590 bug around git user names/emails #591
Merged
DougMidgley
merged 5 commits into
develop
from
feature/554-auto-generate-markets-and-marketlist-upon-mcdev-init
Dec 8, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoernBerkefeld
added
the
enhancement
New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
label
Dec 8, 2022
if (hideOutput) { | ||
// no output displayed to user but instead returned to parsed elsewhere | ||
return child_process | ||
.execSync(cmd + ' ' + args.join(' ')) |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
This string concatenation which depends on [library input](1) is later used in a [shell command](2).
} else { | ||
// the following options ensure the user sees the same output and | ||
// interaction options as if the command was manually run | ||
child_process.execSync(cmd + ' ' + args.join(' '), { stdio: [0, 1, 2] }); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
This string concatenation which depends on [library input](1) is later used in a [shell command](2).
5 tasks
JoernBerkefeld
changed the title
Feature/554 auto generate markets and marketlist upon mcdev init
Feature/554 auto generate markets and marketlist upon mcdev init + #590 chore
Dec 8, 2022
2 tasks
JoernBerkefeld
changed the title
Feature/554 auto generate markets and marketlist upon mcdev init + #590 chore
Feature/554 auto generate markets and marketlist upon mcdev init + fixes #590 bug around git user names/emails
Dec 8, 2022
DougMidgley
approved these changes
Dec 8, 2022
DougMidgley
deleted the
feature/554-auto-generate-markets-and-marketlist-upon-mcdev-init
branch
December 8, 2022 12:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details
What is the purpose of this pull request?
What changes did you make? (Give an overview)
when
mcdev init
is executed it now auto-populatesmarkets
andmarketList
in the config with actual values based on the retrieved list of BUs. We ask the user which BU is the development BU to properly fill deployment-source vs deployment-target lists. Also, we exclude ParentBU in these market lists.Is there anything you'd like reviewers to focus on?
suffix
, and so far, the value we fill is "underscore + buName". That's a placeholder.--y.developmentBu=myBuName
or leave it empty, which shows a warning and pushes all BUs (except parent) into the target list.Checklist
npm run test
to with 0 tests failing