Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/630 refresh emails in active triggeredsends journeys #643

Merged
merged 16 commits into from
Jan 23, 2023
Merged

Feature/630 refresh emails in active triggeredsends journeys #643

merged 16 commits into from
Jan 23, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jan 20, 2023 •
edited
Loading

PR details

What is the purpose of this pull request? (put an "X" next to an item)

  • Add a CLI option

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld
#630: add generic refresh method
f142660
@JoernBerkefeld
Merge branch 'feature/627-add-updateinsert-support-for-journeys-inter…
9715deb 
…action' into feature/630-refresh-emails-in-active-triggeredsends-journeys

# Conflicts:
#	docs/dist/documentation.md
@JoernBerkefeld
#630: refactoring - get buObject from class, not as fn-param
60563d7
@JoernBerkefeld
#630: move to standardized type check
0d44ac7
@JoernBerkefeld
#630: fix eslint warnings for return values
fe1aa56
@JoernBerkefeld
#630: making type optional, because only 1 type is supported at this …
1ca5a40 
…time
@JoernBerkefeld
#630: add TSD refresh logic to ensure changes to emails are getting p…
42199fd 
…icked up
@JoernBerkefeld
#630: Allow limiting refresh by given TSD keys
63dd048
@JoernBerkefeld
Merge branch 'develop' into feature/630-refresh-emails-in-active-trig…
b828526 
…geredsends-journeys
@JoernBerkefeld
#630: improve error handling and log output for refresh TSD
c4bd665
@JoernBerkefeld JoernBerkefeld added this to the 4.3.0 milestone Jan 20, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 20, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Jan 20, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Jan 20, 2023 that may be closed by this pull request
[FEATURE] refresh emails in active triggeredSends / journeys #630
Closed
@JoernBerkefeld
Merge branch 'develop' into feature/630-refresh-emails-in-active-trig…
343fc2b 
…geredsends-journeys

# Conflicts:
#	docs/dist/documentation.md
#	lib/metadataTypes/MetadataType.js
@JoernBerkefeld
Merge branch 'feature/627-add-updateinsert-support-for-journeys-inter…
2390560 
…action' into feature/630-refresh-emails-in-active-triggeredsends-journeys
@JoernBerkefeld JoernBerkefeld changed the base branch from develop to feature/627-add-updateinsert-support-for-journeys-interaction January 23, 2023 11:04
DougMidgley
DougMidgley previously approved these changes Jan 23, 2023
View reviewed changes
Base automatically changed from feature/627-add-updateinsert-support-for-journeys-interaction to develop January 23, 2023 17:41
@JoernBerkefeld
Merge branch 'develop' into feature/630-refresh-emails-in-active-trig…
7e0a440 
…geredsends-journeys

# Conflicts:
#	docs/dist/documentation.md
#	lib/index.js
#	lib/metadataTypes/Interaction.js
#	lib/metadataTypes/MetadataType.js
@JoernBerkefeld
Copy link
Contributor Author

will go ahead with merge as discussed (and approved earlier)

@JoernBerkefeld JoernBerkefeld merged commit 46d2cff into develop Jan 23, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/630-refresh-emails-in-active-triggeredsends-journeys branch January 23, 2023 18:10
@github-actions github-actions bot mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougMidgley DougMidgley DougMidgley left review comments

Assignees

@JoernBerkefeld JoernBerkefeld

Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] refresh emails in active triggeredSends / journeys
2 participants
@JoernBerkefeld @DougMidgley