Bugfix/542 emailSendDefinition deploy breaks due to missing email asset #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing emailSendDefinition
…mailsenddefinition-deploy-breaks-due-to-missing-email-asset
…wont-be-found-on-child-bus' into 542-bug-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
…efinition-deploy-breaks-due-to-missing-email-asset
…-due-to-missing-email-asset
…senddefinition-deploy-breaks-due-to-missing-email-asset
was already there outside of array
…oap' into 542-bug-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
…oap' into 542-bug-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
…senddefinition-deploy-breaks-due-to-missing-email-asset
…id-during-retrieve-of-triggeredsend' into 542-bug-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
…eve' into 542-bug-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
…aks-due-to-missing-email-asset # Conflicts: # lib/metadataTypes/definitions/EmailSendDefinition.definition.js
|
latest tests have shown that i can easily duplicate existing emailSendDefinitions now. |
JoernBerkefeld
changed the title
JoernBerkefeld
deleted the
bugfix/542-emailsenddefinition-deploy-breaks-due-to-missing-email-asset
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
previous PR #549 was closed when the branch got renamed. hence this new PR
during deploy tests, after fixing the obvious issues with SenderProfile, DeliveryProfile and SendClassification, I've been getting error 42117. Looking at https://developer.salesforce.com/docs/marketing/marketing-cloud/guide/42000_42999_emailsenddefinition_object.html that error stands for ESD_Invalid ObjectID = Invalid ObjectID
could make sense during an update. but why during create?!
now we get a 42116.... null value.
tested a lot but so far no idea whats wrong now.
Checklist