Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#706: refresh triggeredSends on email update (deploy) #721

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Feb 7, 2023

PR details

What changes did you make? (Give an overview)

this adds a new option to deploy which calls refresh under the hood to update the right triggeredSends after updating assets. not implemented for other types!

Example:
mcdev deploy --refresh

Checklist

@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Feb 7, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 7, 2023
@JoernBerkefeld JoernBerkefeld linked an issue Feb 7, 2023 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Feb 7, 2023
@JoernBerkefeld JoernBerkefeld changed the title #706: deploy: convert fromRetrieve into option; add option refresh #706: deploy: add option refresh Feb 8, 2023
@JoernBerkefeld JoernBerkefeld changed the title #706: deploy: add option refresh #706: refresh triggeredSends on email update (deploy) Feb 8, 2023
@JoernBerkefeld JoernBerkefeld changed the base branch from develop to feature/723-convert-deploy-fromretrieve-into-option-fromretrieve February 8, 2023 13:23
…mretrieve' into feature/706-refresh-triggeredsends-on-email-update
Base automatically changed from feature/723-convert-deploy-fromretrieve-into-option-fromretrieve to develop February 8, 2023 13:30
@JoernBerkefeld
Copy link
Contributor Author

im pushing this forward now because it seems we don't have time to discuss the fundamental problem that you see with my approach. if needed, we can solve that later with a new task.

…h-triggeredsends-on-email-update

# Conflicts:
#	docs/dist/documentation.md
@JoernBerkefeld JoernBerkefeld merged commit d4e7b9c into develop Mar 24, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/706-refresh-triggeredsends-on-email-update branch March 24, 2023 12:47
@JoernBerkefeld JoernBerkefeld restored the feature/706-refresh-triggeredsends-on-email-update branch March 24, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] refresh triggeredSends on email update
2 participants