Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 4.3.4 #764

Merged
merged 24 commits into from
Feb 21, 2023
Merged
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d5fcec5
#748: fully resolve asset-template content
JoernBerkefeld Feb 17, 2023
f7776e3
#748: standardize asset-message main content's file name
JoernBerkefeld Feb 17, 2023
ba8b301
#748: standardize asset-template's main extract's file name
JoernBerkefeld Feb 17, 2023
58ba657
#750: fix deploying only specified subtype
JoernBerkefeld Feb 17, 2023
a30f40f
#0: add "create PR to hotfix branch" for gitfork
JoernBerkefeld Feb 17, 2023
1a4c7cf
#750: explain type rewrites
JoernBerkefeld Feb 17, 2023
5951876
Merge pull request #751 from Accenture/bugfix/750-deploy-asset-subtyp…
JoernBerkefeld Feb 17, 2023
43edec6
Merge remote-tracking branch 'origin/hotfix' into bugfix/748-asset-te…
JoernBerkefeld Feb 17, 2023
7513f98
Merge pull request #752 from Accenture/bugfix/748-asset-template-can-…
JoernBerkefeld Feb 17, 2023
4b9709c
#747: SSJS support for codesnippets
JoernBerkefeld Feb 17, 2023
3ee3c56
#0: fix field-unknown debug msgs for the MIDs saved inside of busines…
JoernBerkefeld Feb 20, 2023
299d548
#747: add robust way of deciding if code block is SSJS or not and ext…
JoernBerkefeld Feb 20, 2023
c4a571b
#0: cleanup old code
JoernBerkefeld Feb 20, 2023
3343d1c
#747: improve regex to recognize edge cases
JoernBerkefeld Feb 20, 2023
4ddac12
Merge pull request #754 from Accenture/bugfix/747-code-snippets-made-…
JoernBerkefeld Feb 20, 2023
4db81cf
#747: clean up logs
JoernBerkefeld Feb 20, 2023
3c60fe5
Merge pull request #758 from Accenture/bugfix/747-code-snippets-made-…
JoernBerkefeld Feb 20, 2023
d5280d2
#706: ensure metadata is fully copied with all its extracted code blo…
JoernBerkefeld Feb 21, 2023
db8ba4e
#761: fix deploy folder not getting purged by createDeltaPkg
JoernBerkefeld Feb 21, 2023
8f58b87
Merge pull request #762 from Accenture/bugfix/757-cdp-command-does-no…
JoernBerkefeld Feb 21, 2023
1d64c04
#753: fix retrieve asset-subtype key
JoernBerkefeld Feb 21, 2023
623d775
Merge pull request #763 from Accenture/bugfix/753-regression-retrieve…
JoernBerkefeld Feb 21, 2023
66dd6ea
4.3.4
JoernBerkefeld Feb 21, 2023
bda0788
#0: prep 4.3.4
JoernBerkefeld Feb 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .fork/.prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"useTabs": false,
"tabWidth": 2,
"printWidth": 40,
"trailingComma": "none"
}
14 changes: 13 additions & 1 deletion .fork/custom-commands.json
Original file line number Diff line number Diff line change
@@ -10,5 +10,17 @@
"type": "url",
"url": "https://github.com/Accenture/sfmc-devtools/compare/develop...$shortname?expand=1"
}
},
{
"name": "Create PR to hotfix branch",
"target": "ref",
"refTargets": [
"localbranch",
"remotebranch"
],
"action": {
"type": "url",
"url": "https://github.com/Accenture/sfmc-devtools/compare/hotfix...$shortname?expand=1"
}
}
]
]
7 changes: 4 additions & 3 deletions lib/Deployer.js
Original file line number Diff line number Diff line change
@@ -239,13 +239,14 @@ class Deployer {
);
}
const foundDeployTypes = Object.keys(this.metadata)
// remove empty types
.filter((type) => Object.keys(this.metadata[type]).length)
// make sure we keep the subtype in this list if that's what the user defined
.map((type) =>
type === 'asset' && Util.includesStartsWith(typeArr, type)
? typeArr[Util.includesStartsWithIndex(typeArr, type)]
: type
)
// remove empty types
.filter((type) => Object.keys(this.metadata[type]).length);
);
if (!foundDeployTypes.length) {
throw new Error('No metadata found for deployment');
}