Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/139 add user deploy support - fixes #814

Merged
merged 29 commits into from
Mar 27, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 22, 2023

PR details

What changes did you make? (Give an overview)

  • added "(Key: ...)" info after "Downloaded: x" for SOAP retrieves (so far this was only happening for REST retrieves)
  • made "Requesting next batch..." gray given its lesser importance
  • fixes [FEATURE] add user deploy support #139
    • allowed @ in filenames
    • renamed xxx__c fields to c__xxx to match the mcdev standard
    • removed c__AssociatedBusinessUnits from deploy payload
    • fix BU listing in document user's md file
    • add option to unlock users (those with IsLocked=true) by setting Unlock=true
    • the initial release was only tested on our internal server where it worked great
    • testing it on a client server with 90+ BUs and 2700+ users / installed packages some of the SFMC APIs broke down:
      • AccountUserAccount (BU assignments) only returned 20-25 BUs per user, even if 90 were assigned when trying to retrieve all without filter. Adding a filter with all AccountUserIDs had the same result --> Working through it 100 users at a time worked though.
      • AccountUser worked fine for the first 2500 returned records but on the 2nd page it would not return Roles nor UserPermissions anymore. --> decided to split the request into active users, inactive users, installed packages

Retrieve all:
image

Retrieve by key:
image

Deploy single user:
image

Deploy blocked due to Marketing Cloud role:
image

Checklist

@JoernBerkefeld JoernBerkefeld added the c/user COMPONENT label Mar 22, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Mar 22, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 22, 2023
@github-actions github-actions bot added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Mar 22, 2023
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review March 22, 2023 18:33
@JoernBerkefeld JoernBerkefeld merged commit b92240c into develop Mar 27, 2023
@JoernBerkefeld JoernBerkefeld deleted the feature/139_add_user_deploy_support_fixes branch March 27, 2023 13:49
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/user COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant