Feature/819 add api option to get request response printed to log #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| '<fueloauth>*** TOKEN REMOVED ***</fueloauth>' | ||
| ); | ||
| } else if (msg.headers?.Authorization) { | ||
| msg.headers.Authorization = 'Bearer *** TOKEN REMOVED ***'; |
Check failure
Code scanning / CodeQL
Hard-coded credentials
JoernBerkefeld
deleted the
feature/819-add-api-option-to-get-request-response-printed-to-log
branch
DougMidgley
reviewed
Mar 28, 2023
| @@ -469,23 +469,27 @@ const Util = { | |||
| if (argv.silent) { | |||
| // only errors printed to CLI | |||
| Util.logger.level = 'error'; | |||
| Util.OPTIONS.loggerLevel = 'error'; | |||
There was a problem hiding this comment.
do we need this? or can we just set the line above?
There was a problem hiding this comment.
the first one we need, the second one we technically don't. I figured it's good practice to have it all in one place though for reference by other classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR details
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
...
Checklist