Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#861: add code coverage comments to PRs #862

Merged
merged 22 commits into from
Apr 17, 2023
Merged

#861: add code coverage comments to PRs #862

merged 22 commits into from
Apr 17, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld self-assigned this Apr 17, 2023
@github-actions github-actions bot added the chore Jira issue-type "Task" label Apr 17, 2023
@JoernBerkefeld
#861: fix path issue
9a94cb8
@JoernBerkefeld
#861: splitting off CodeQL
d6e0c52
@JoernBerkefeld
#861: add template file for coverage comments
c5ac57e 
it's required to have one in your repo
@JoernBerkefeld
#861: attempt with all coverage ymls
8d5fecc
@JoernBerkefeld
#861: switch to coverage task for report and run npm ci instead of npm i
fbb6683
@JoernBerkefeld
#861: remove unneded code
304701e
@JoernBerkefeld
#861: remove configuration in favor of github default
648c5eb
@JoernBerkefeld
#861: rename testing workflow to not clash with codeQL standards
1ee45a9
@JoernBerkefeld
#861: ensure coverage/ is created
d193a62
@JoernBerkefeld
#861: fix search_artifacts param of dawidd6/action-download-artifact@v2
265b40d
@JoernBerkefeld
#861: upgrade actions/upload-artifact v2 to v3
0e77a96
@JoernBerkefeld
#861: bump andstor/file-existence-action from v1 to 2
34d0d2c
@JoernBerkefeld
#861: include actions/setup-node@v3
68aaa46
@JoernBerkefeld
#861: disable custom fetch
e42def8
@JoernBerkefeld
#861: fix path to coverage action
23143df
@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited
Loading

Coverage Report

Commit: fe3a5f6
Base: develop@e4f8a2c

Type This PR
Total Statements Coverage  40.19%
Total Branches Coverage  31%
Total Functions Coverage  45.86%
Total Lines Coverage  40.15%
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld
Copy link
Contributor Author

merging in hope of getting more results afterwards

@JoernBerkefeld JoernBerkefeld merged commit 08e68ae into develop Apr 17, 2023
@JoernBerkefeld JoernBerkefeld deleted the task/861-add-test-coverage-to-pull-requests branch April 17, 2023 13:00
@JoernBerkefeld JoernBerkefeld restored the task/861-add-test-coverage-to-pull-requests branch April 17, 2023 13:00
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Closed
@JoernBerkefeld JoernBerkefeld linked an issue Apr 17, 2023 that may be closed by this pull request
[TASK] add test coverage to pull requests #861
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] add test coverage to pull requests
1 participant
@JoernBerkefeld