Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#871: fix update for type event #872

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Apr 22, 2023

now uses generic method instead of outdated fuelSDK custom logic

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [nope] test scripts updated
  • n/a Wiki updated (if applicable)

now uses generic method instead of outdated fuelSDK custom logic
@JoernBerkefeld JoernBerkefeld added the c/event COMPONENT label Apr 22, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.0 milestone Apr 22, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 22, 2023
@github-actions github-actions bot added the bug Something isn't working label Apr 22, 2023
@github-actions
Copy link

github-actions bot commented Apr 22, 2023

Coverage Report

Commit: 867f143
Base: develop@f2338f6

Type Base This PR
Total Statements Coverage  40.19%  40.25%  (+0.06%)
Total Branches Coverage  31%  31.04%  (+0.04%)
Total Functions Coverage  45.86%  45.86%  (+0%)
Total Lines Coverage  40.15%  40.21%  (+0.06%)
Details (changed testable files):
File Statements Branches Functions Lines
lib/metadataTypes/Event.js  16.32%  0%  9.09%  16.66%

@JoernBerkefeld JoernBerkefeld linked an issue Apr 22, 2023 that may be closed by this pull request
2 tasks
@JoernBerkefeld JoernBerkefeld changed the title #871: fix update-event #871: fix update for type event Apr 24, 2023
@JoernBerkefeld JoernBerkefeld merged commit eb1eed7 into develop Apr 24, 2023
@JoernBerkefeld JoernBerkefeld deleted the bugfix/871-update-event-broken-because-logic-still-uses-fuelsdk-parameters branch April 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/event COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] update event broken because logic still uses FuelSDK parameters
1 participant