Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-unicorn from 46.0.0 to 47.0.0 #897

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Deployer.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class Deployer {
/**
* Creates a Deployer, uses v2 auth if v2AuthOptions are passed.
*
*
* @param {TYPE.Mcdevrc} properties General configuration to be used in retrieve
* @param {TYPE.BuObject} buObject properties for auth
*/
Expand Down
2 changes: 1 addition & 1 deletion lib/metadataTypes/Asset.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ class Asset extends MetadataType {
rightOperand: {
property: 'id',
simpleOperator: 'greaterThan',
value: items[items.length - 1].id,
value: items.at(-1).id,
},
};
lastPage = 0;
Expand Down
4 changes: 2 additions & 2 deletions lib/metadataTypes/User.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,12 @@ class User extends MetadataType {
);

if (action === 'create') {
const createItem = metadataToCreate[metadataToCreate.length - 1];
const createItem = metadataToCreate.at(-1);
User._setPasswordForNewUser(createItem);
User._prepareRoleAssignments({ after: createItem });
User._prepareBuAssignments(metadata[metadataKey], null, createItem);
} else if (action === 'update') {
const updateItem = metadataToUpdate[metadataToUpdate.length - 1];
const updateItem = metadataToUpdate.at(-1);
User._prepareRoleAssignments(updateItem);
User._prepareBuAssignments(metadata[metadataKey], updateItem, null);
}
Expand Down
4 changes: 4 additions & 0 deletions lib/util/auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ let authfile;
const Auth = {
/**
* For each business unit, set up base credentials to be used.
*
* @param {TYPE.AuthObject} authObject details for
* @param {string} credential of the instance
* @returns {void}
Expand Down Expand Up @@ -47,6 +48,7 @@ const Auth = {
},
/**
* Returns an SDK instance to be used for API calls
*
* @param {TYPE.BuObject} buObject information about current context
* @returns {SDK} auth object
*/
Expand All @@ -71,6 +73,7 @@ const Auth = {
},
/**
* helper to clear all auth sessions
*
* @returns {void}
*/
clearSessions() {
Expand All @@ -80,6 +83,7 @@ const Auth = {
};
/**
* Returns an SDK instance to be used for API calls
*
* @param {string} sessionKey key for specific BU
* @param {TYPE.AuthObject} authObject credentials for specific BU
* @returns {SDK} auth object
Expand Down
92 changes: 49 additions & 43 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"eslint-plugin-jsdoc": "44.2.4",
"eslint-plugin-mocha": "10.1.0",
"eslint-plugin-prettier": "4.2.1",
"eslint-plugin-unicorn": "46.0.0",
"eslint-plugin-unicorn": "47.0.0",
"fast-xml-parser": "4.2.2",
"husky": "8.0.3",
"jsdoc-to-markdown": "8.0.0",
Expand Down