Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/912 ensure mcdev collaborators auto update their dependencies on git pull #913

Merged
merged 21 commits into from
May 17, 2023
Merged

Task/912 ensure mcdev collaborators auto update their dependencies on git pull #913

merged 21 commits into from
May 17, 2023

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 17, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

This covers git checkout/switch and git merge. It checks if package-lock.json was changed as part of a merge or if it is was different on the previous branch. If true, it automatically runs npm install. This will ensure collaborators always work with the dependencies specified in package.json / package-lock.json. One cannot forget to run npm install anymore.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • n/a test scripts updated
  • n/a Wiki updated (if applicable)

@JoernBerkefeld
#912: run npm install on git checkout, merge if necessary and always …
a0e7e60 
…on git clone
@JoernBerkefeld
#912: enable debugging temporarily
5d9afc9
@JoernBerkefeld
#912: refactoring
ab4be95
@JoernBerkefeld
#912: debug msgs
1e418cb
@JoernBerkefeld
#912: attempt at fixing error
cd43d9b
@JoernBerkefeld
#912: improve log output for when no updates are required
13de337
@JoernBerkefeld
#912: improve hook logs
3c42ae4
@JoernBerkefeld
#912: fix call to git diff
48a19da
@JoernBerkefeld
#912: install something for testing purposes
16a290c
@JoernBerkefeld
Merge branch 'task/912-git-hook-test' into task/912-ensure-mcdev-coll…
ccd4122 
…aborators-auto-update-their-dependencies-on-git-pull

# Conflicts:
#	.husky/post-checkout
#	.husky/post-merge
@JoernBerkefeld
#912: test
bf9e4f3
@JoernBerkefeld
#912: HUSKY_GIT_PARAMS
5c279fb 
https://typicode.github.io/husky/#manually
@JoernBerkefeld
#912: test git parameters
b2cf57b
@JoernBerkefeld
#912: debug info
e28f540
@JoernBerkefeld
#912: fiddle with variables
c2d21f5
@JoernBerkefeld
#912: turn PACKAGES into an array
16d12bd
@JoernBerkefeld
#912: fix array
dee8d3a
@JoernBerkefeld
#912: fix errorCode 1 when nothing was found
a7fcc6d
@JoernBerkefeld
#912: refactoring
f0aff18
@JoernBerkefeld
#912: remove test install
5223df8
@JoernBerkefeld
#912: cleanup
3c84ef0
@JoernBerkefeld JoernBerkefeld added this to the 5.0.2 milestone May 17, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 17, 2023
@github-actions github-actions bot added the chore Jira issue-type "Task" label May 17, 2023
@JoernBerkefeld JoernBerkefeld linked an issue May 17, 2023 that may be closed by this pull request
[TASK] ensure mcdev collaborators auto-update their dependencies on git pull #912
Closed
@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited
Loading

Coverage Report

Commit: 3c84ef0
Base: develop@3615299

Type Base This PR
Total Statements Coverage  40.82%  40.82%  (+0%)
Total Branches Coverage  32.31%  32.31%  (+0%)
Total Functions Coverage  47.17%  47.17%  (+0%)
Total Lines Coverage  40.76%  40.76%  (+0%)
Details (changed testable files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 45d29e8 into develop May 17, 2023
@JoernBerkefeld JoernBerkefeld deleted the task/912-ensure-mcdev-collaborators-auto-update-their-dependencies-on-git-pull branch May 17, 2023 14:53
@github-actions github-actions bot mentioned this pull request May 17, 2023
Closed
@JoernBerkefeld JoernBerkefeld mentioned this pull request May 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
chore Jira issue-type "Task"
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

[TASK] ensure mcdev collaborators auto-update their dependencies on git pull
1 participant
@JoernBerkefeld