Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/#923: corrected dataExtensionField rename log message #929

Merged
merged 2 commits into from
May 24, 2023
Merged

bugfix/#923: corrected dataExtensionField rename log message #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc33a05
#923: corrected dataExtensionField rename log message
JoernBerkefeld May 24, 2023
61591a0
#923: add empty test for renaming fields
JoernBerkefeld May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/metadataTypes/DataExtensionField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ class DataExtensionField extends MetadataType {

// enable renaming
if (item.Name_new) {
Util.logger.info(
` - Found Name_new='${item.Name_new}' for field ${deKey}.${item.Name} - trying to rename.`
);
item.Name = item.Name_new;
delete item.Name_new;
Util.logger.warn(
` - Found 'Name_new' value '${item.Name_new}' for ${deKey}.${item.Name} - trying to rename.`
);
}

// check if any changes were found
Expand Down Expand Up @@ -210,8 +210,8 @@ class DataExtensionField extends MetadataType {
}
}
if (item.Name_new) {
Util.logger.warn(
` - Found 'Name_new' value '${item.Name_new}' for ${deKey}.${item.Name} but could not find a corresponding DE field on the server - adding new field instead of updating.`
Util.logger.info(
` - Found Name_new='${item.Name_new}' for field ${deKey}.${item.Name} but could not find a corresponding DE field on the server - adding new field instead of updating.`
);
delete item.Name_new;
}
Expand Down
1 change: 1 addition & 0 deletions test/type.dataExtension.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ describe('type: dataExtension', () => {
return;
});
it('Should change the key during update via --changeKeyValue');
it('Should rename fields');
});
describe('Templating ================', () => {
it('Should create a dataExtension template via retrieveAsTemplate and build it', async () => {
Expand Down