Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/964: define actual maxKeyLength per type for changeKeyX #970

Conversation

JoernBerkefeld
Copy link
Contributor

PR details

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • n/a test scripts updated
  • n/a Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 5.1.0 milestone Jun 6, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jun 6, 2023
@github-actions github-actions bot added the bug Something isn't working label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage Report

Commit: 3a2da96
Base: develop@9ff3bc3

Type Base This PR
Total Statements Coverage  45.98%  45.99%  (+0.01%)
Total Branches Coverage  36.69%  36.73%  (+0.04%)
Total Functions Coverage  53.02%  53.02%  (+0%)
Total Lines Coverage  45.9%  45.91%  (+0.01%)
Details (changed testable files):
File Statements Branches Functions Lines
lib/metadataTypes/MetadataType.js  63.66%  62.42%  73.49%  63.46%

@JoernBerkefeld JoernBerkefeld changed the title bugfix/964: define actual maxKeyLength per type bugfix/964: define actual maxKeyLength per type for changeKeyX Jun 6, 2023
@JoernBerkefeld JoernBerkefeld merged commit d3dd9d5 into develop Jun 6, 2023
@JoernBerkefeld JoernBerkefeld deleted the bugfix/964-allow-200-chars-for-dataextensions-keys-on-changekeyx branch June 6, 2023 07:06
@JoernBerkefeld JoernBerkefeld linked an issue Jun 6, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] allow 200 chars for dataExtensions keys on changeKeyX
1 participant