Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/988 read refresh from options #992

Merged
merged 13 commits into from
Jun 27, 2023
Merged

bugfix/988 read refresh from options #992

merged 13 commits into from
Jun 27, 2023

Conversation

phjulia
Copy link
Collaborator

@phjulia phjulia commented Jun 16, 2023 •
edited by JoernBerkefeld
Loading

PR details

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • N/A test scripts updated
  • N/A Wiki updated (if applicable)

@phjulia phjulia linked an issue Jun 16, 2023 that may be closed by this pull request
[BUG] --refresh on deploy does not refresh triggered send #988
Closed
2 tasks
@phjulia phjulia changed the base branch from main to develop June 16, 2023 19:42
@github-actions github-actions bot added the bug Something isn't working label Jun 16, 2023
@phjulia phjulia requested a review from JoernBerkefeld June 16, 2023 19:42
@github-actions
Copy link

github-actions bot commented Jun 16, 2023 •
edited
Loading

Coverage Report

Commit:73e14da
Base: develop@4466da0

Type Base This PR
Total Statements Coverage  46.04%  46.07%  (+0.03%)
Total Branches Coverage  36.98%  36.91%  (-0.07%)
Total Functions Coverage  52.89%  53.03%  (+0.14%)
Total Lines Coverage  45.96%  45.99%  (+0.03%)
Details (changed files):
File Statements Branches Functions Lines

@phjulia phjulia marked this pull request as draft June 16, 2023 19:47
@phjulia phjulia self-assigned this Jun 24, 2023
JoernBerkefeld
JoernBerkefeld requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test class for asset to ensure this keeps working?

lib/metadataTypes/TriggeredSend.js Outdated Show resolved Hide resolved
@JoernBerkefeld JoernBerkefeld changed the title 988-bug/read refresh from options bugfix/988 read refresh from options Jun 26, 2023
@JoernBerkefeld
Merge remote-tracking branch 'origin/develop' into bugfix/988-bug-ref…
0f99683 
…resh-on-deploy-does-not-refresh-triggered-send
@JoernBerkefeld
Copy link
Contributor

asset test class shall be done as part of:

that ensures we can push out this bugfix faster

@JoernBerkefeld JoernBerkefeld added this to the 5.1.1 milestone Jun 27, 2023
@JoernBerkefeld JoernBerkefeld marked this pull request as ready for review June 27, 2023 12:40
@JoernBerkefeld
Merge remote-tracking branch 'origin/develop' into bugfix/988-bug-ref…
73e14da 
…resh-on-deploy-does-not-refresh-triggered-send
@JoernBerkefeld JoernBerkefeld merged commit 56ecfd2 into develop Jun 27, 2023
@JoernBerkefeld JoernBerkefeld deleted the bugfix/988-bug-refresh-on-deploy-does-not-refresh-triggered-send branch June 27, 2023 13:19
@JoernBerkefeld JoernBerkefeld removed this from the 5.2.1 milestone Jun 29, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.2.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoernBerkefeld JoernBerkefeld JoernBerkefeld approved these changes

Assignees

@phjulia phjulia

Labels
bug Something isn't working
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

[BUG] --refresh on deploy does not refresh triggered send
2 participants
@phjulia @JoernBerkefeld