feat: Support the enumn crate in all public enums #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwcampbell You forgot to include the changes to |
|
It turns out that no such changes are needed, because the accesskit crate already has an optional dependency on enumn (and therefore, an enumn feature); that dependency/feature was needed for our serialization implementation. |
DataTriny
approved these changes
Aug 2, 2023
|
Indeed you're right, I missed that. |
|
Merged as a fix rather than a feature because it's not a breaking change, and I don't want to bump semver-major version numbers for something this small. |
Merged
lunixbochs
pushed a commit
to talonvoice/accesskit
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I need this for my JNI bindings.