Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to ZBus v4 #456

Merged
merged 6 commits into from
Oct 7, 2024
Merged

fix: update to ZBus v4 #456

merged 6 commits into from
Oct 7, 2024

Conversation

fogti
Copy link
Contributor

@fogti fogti commented Sep 30, 2024

This also requires bumps to

  • atspi v0.19 -> v0.22
  • atspi-common v0.3 -> v0.6
  • zbus v3.14 -> v4.4
  • zvariant v3 -> v4.2

This is motivated by wanting to reduce the amount of dependencies on syn v1.

@DataTriny
Copy link
Member

Hello @fogti and thank you for working on this.

We first needed to increase the MSRV to 1.75, this is the main reason why I didn't do this before. #457 was just merged, can you please rebase?

This also requires bumps to
* atspi        v0.19 -> v0.22
* atspi-common v0.3  -> v0.6
* zbus         v3.14 -> v4.4
* zvariant     v3    -> v4.2
Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The winit example still runs fine.

@DataTriny
Copy link
Member

@mwcampbell would you like to do a quick review as well?

@mwcampbell
Copy link
Contributor

My only concern is the size of Cargo.lock. @fogti Did you run cargo update on this workspace? If so, please revert your changes to Cargo.lock on this branch, run cargo build in platforms/unix, and commit the Cargo.lock that comes out of that. I've done this on my end and verified that the changes to Cargo.lock are much easier to review this way. I think we should establish a policy that only project owners can do an unrestricted cargo update, to minimize the risk of hiding a supply chain attack in the middle of an overwhelming set of changes to Cargo.lock.

@fogti
Copy link
Contributor Author

fogti commented Oct 7, 2024

sorry for that; just wanted to test that an cargo update actually manages to get rid of syn 1.*, and forgot to do it properly after that.

@mwcampbell
Copy link
Contributor

Looks good now, thanks.

@DataTriny If you agree, please merge when CI is done.

@DataTriny DataTriny merged commit 95db8f1 into AccessKit:main Oct 7, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
@DataTriny
Copy link
Member

Thank you again @fogti!

@fogti fogti deleted the port-to-zbus4 branch October 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants