Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update some dependencies to remove duplicates #464

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

DataTriny
Copy link
Member

@DataTriny DataTriny commented Oct 8, 2024

We are able to remove all duplicates by updating the following crates:

  • async-channel to 2.3.1
  • enumn to 0.1.14
  • schemars to 0.8.21
  • thiserror to 1.0.64

@fogti
Copy link
Contributor

fogti commented Oct 9, 2024

It shouldn't be necessary to force patch bumps via Cargo.toml at all tho, bumping only async-channel in Cargo.toml and checking that it doesn't affect this new updated Cargo.lock should suffice.

I was able to confirm this by running:

git switch -c remove-duplicate-deps-2
git checkout remove-duplicate-deps Cargo.lock
sed -i -e 's/2\.1\.1/2\.3/g' platforms/unix/Cargo.toml
cargo test

@DataTriny
Copy link
Member Author

@fogti It surely would work but updating Cargo.toml directly is more explicit. Do you have a particular reason for pushing back on this?

@mwcampbell
Copy link
Contributor

Here's why I also think it would be better to just update our Cargo.lock and not the crate manifests:

Updating the version numbers in the crate manifests implies that the minimum versions we require all downstream users to use for those crates has changed. But that's not the case. We're just doing a bit of cleanup on our own dependency graph as specified in our own Cargo.lock. Also, this approach would let us downgrade this PR from a fix to a chore, not triggering a release.

@DataTriny
Copy link
Member Author

Reverted all my changes then used cargo update with all the crates mentioned above. We end up with the same lock file.

@DataTriny DataTriny changed the title fix: Update some dependencies to remove duplicates chore: Update some dependencies to remove duplicates Oct 13, 2024
@mwcampbell mwcampbell merged commit cf33013 into main Oct 13, 2024
9 checks passed
@mwcampbell mwcampbell deleted the remove-duplicate-deps branch October 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants