-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub roles to MacOS adapter #480
Add sub roles to MacOS adapter #480
Conversation
We do have these roles and I think they are all named exactly like Chromium's. Please add them if possible.
By giving
By giving |
I dont see any of the math roles in the list of roles: https://github.com/AccessKit/accesskit/blob/main/common/src/lib.rs#L55 Are they defined somewhere else? |
Woops, sorry. We must have removed them at some point. Please do the same. |
With the changes from this PR, tabs are correctly announced as tabs by VoiceOver. This can be tested by running the gallery example from my fork of Slint. I've updated the PR description accordingly. |
I don't recall dropping math roles. It's more likely that when I copied the roles from Chromium in July 2021, those roles didn't exist yet. |
Yes, they were added in October 2021, so right after you copied the roles :) |
Co-authored-by: Arnold Loubriat <datatriny@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HolgerGottChristensen!
Adds initial support for accessibility sub roles to the MacOS adapter, allowing AccessKit to expose Toggle buttons, Switch and more, correctly to VoiceOver.
Needed clarifications:
Role::SearchInput
)Role::PasswordInput
)Fixes #477
Fixes #372