Skip to content

Conversation

jchannon
Copy link
Contributor

Attempt at #9.

Beautify also ran against source.

main.js Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Panel shouldn't be closed by exit. It depends whether the user closes the panel or terminates the process, see https://github.com/Acconut/brackets-nodejs/blob/master/main.js#L248-L254.

@Acconut
Copy link
Owner

Acconut commented Feb 22, 2014

This is quite a lot, I'll have a look.
But I'm not sure yet whether I like the exec-panel's removal.

@jchannon
Copy link
Contributor Author

To summarize, I've removed the exec modal and put a textbox on the terminal
panel.

The terminal can be opened via Alt+T

The last commands are stored in an array up to a max of 10 items

The up and down keys when the textbox has focus will go through the last
commands array and populate it with the command. You can then hit enter or
click the arrow button to execute it.

@Acconut
Copy link
Owner

Acconut commented Feb 26, 2014

Another option would be to use the new datalists (http://davidwalsh.name/datalist). It's a bit fancier because you can see the last commands and not only navigate through them. What do you think?

@jchannon
Copy link
Contributor Author

I guess its an option. I did the keyup/down thing to keep it similar to how
it works in a Terminal :)

@Acconut
Copy link
Owner

Acconut commented Feb 26, 2014

datalists work with keys up and down, too.
I'll try it out and then we can compare :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants