Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for adding iOS device #97

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix for adding iOS device #97

merged 1 commit into from
Jun 27, 2022

Conversation

andriipv
Copy link
Contributor

No description provided.

Copy link
Contributor

@willwade willwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that work if it's an iPad or any other iOS device? What if its called something different?

@andriipv
Copy link
Contributor Author

Current fix is for iPhone only.
You need to try to add iPad device. If it have similar problem I will add fix for iPad too.
Apple devices seems to have other connection logic and they should be identified for different handling.

During connect program checks does device name "iPhone".
If yes it waits when iPhone pairs and give its full name and then adds it to list.
If device name isn't "iPhone" program considers it as full name and adds it to list right away.

@willwade
Copy link
Contributor

Yeah - Ok. Just tested - works properly on iPhone - and no problem seen on iPad. Who knows.. I dare say this might come up again in the future but until then.. Lets get this in there.

@willwade willwade merged commit ad625ca into AceCentre:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants