Skip to content

[Sync] v2.1.2 Main -> Develop #267

Closed
ThirFir wants to merge 3 commits intodevelopfrom
main
Closed

[Sync] v2.1.2 Main -> Develop #267
ThirFir wants to merge 3 commits intodevelopfrom
main

Conversation

@ThirFir
Copy link
Collaborator

@ThirFir ThirFir commented Oct 14, 2025

💻 Work Description

  • v2.1.3 동기화

Summary by CodeRabbit

  • 신규 기능

  • 버그 수정

    • 로그아웃 및 계정 삭제 완료 후 불필요한 온보딩 단계가 다시 나타나던 현상을 제거해 흐름을 매끄럽게 개선했습니다.
    • 캐시 및 세션 정리 이후 일부 화면에서 뜨던 예상치 못한 안내 노출을 줄여 일관성을 높였습니다.
  • 유지 보수

    • 앱 버전 업데이트: 2.1.1 → 2.1.2
    • 버전 코드 갱신으로 배포 식별성 강화

@ThirFir ThirFir self-assigned this Oct 14, 2025
@ThirFir ThirFir changed the title [Sync] v2.1.3 Main -> Develop [Sync] v2.1.2 Main -> Develop Oct 14, 2025
[Release] v2.1.2
@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":404,"request":{"method":"PATCH","url":"https://api.github.com/repos/AconInc/ACON-Android/issues/comments/3400683866","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.5 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: failure by coderabbit.ai -->\n\n> [!CAUTION]\n> ## Review failed\n> \n> The pull request is closed.\n\n<!-- end of auto-generated comment: failure by coderabbit.ai -->\n\n<!-- walkthrough_start -->\n\n## Walkthrough\nsignOut 및 deleteAccount 성공 처리에서 온보딩 플래그 업데이트 호출을 제거하고, 캐시 정리와 세션 정리는 그대로 유지했습니다. 또한 Gradle 버전 정보(projectVersionCode, projectVersionName)를 2.1.2로 증가시켰습니다.\n\n## Changes\n| Cohort / File(s) | Summary |\n| --- | --- |\n| **User sign-out/delete flow**<br>`core/data/src/main/kotlin/com/acon/core/data/repository/UserRepositoryImpl.kt` | signOut/deleteAccount의 onSuccess 블록에서 `updateShouldVerifyArea(true)` 및 `updateShouldChooseDislikes(true)` 호출 제거. 캐시 정리와 세션 정리는 유지. |\n| **Build/versioning**<br>`gradle/libs.versions.toml` | `projectVersionCode` 20010010 → 20010020, `projectVersionName` 2.1.1 → 2.1.2로 업데이트. |\n\n## Sequence Diagram(s)\n```mermaid\nsequenceDiagram\n  autonumber\n  actor U as User\n  participant UR as UserRepositoryImpl\n  participant Auth as AuthService\n  participant Cache as CacheStore\n  participant Sess as SessionManager\n\n  rect rgba(230,245,255,0.6)\n  note over U,UR: signOut / deleteAccount (변경된 성공 처리 흐름)\n  U->>UR: signOut() / deleteAccount()\n  UR->>Auth: request sign-out/delete\n  Auth-->>UR: success\n  UR->>Cache: clear()\n  UR->>Sess: clearSession()\n  UR-->>U: complete\n  end\n\n  rect rgba(255,240,230,0.6)\n  note over UR: 과거 흐름(제거됨)\n  UR -x UR: updateShouldVerifyArea(true) [삭제]\n  UR -x UR: updateShouldChooseDislikes(true) [삭제]\n  end\n```\n\n## Estimated code review effort\n🎯 2 (Simple) | ⏱️ ~10 minutes\n\n## Poem\n> 당근 깃발 흔들며 깡총깡총 뛰네 🥕  \n> 플래그는 가벼워지고, 세션은 말끔히—휙!  \n> 버전은 한 칸 업, 숫자도 반짝 빛나네.  \n> 로그아웃 바람 따라 캐시는 사르르—  \n> 오늘도 릴리즈 정원에 발자국, 톡톡.\n\n<!-- walkthrough_end -->\n\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing touches</summary>\n\n- [ ] <!-- {\"checkboxId\": \"7962f53c-55bc-4827-bfbf-6a18da830691\"} --> 📝 Generate docstrings\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Post copyable unit tests in a comment\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `main`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n\n---\n\n<details>\n<summary>📜 Recent review details</summary>\n\n**Configuration used**: CodeRabbit UI\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between b9944995b49499f72c56edb807e60872812faefe and 23534a9085d47dc11504f9a24ca47fe6c19a8d93.\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (2)</summary>\n\n* `core/data/src/main/kotlin/com/acon/core/data/repository/UserRepositoryImpl.kt` (0 hunks)\n* `gradle/libs.versions.toml` (1 hunks)\n\n</details>\n\n</details>\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=AconInc/ACON-Android&utm_content=267)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcA2gGVZDAYAXUgJACYNAEYNcMgAWW0sMD1IABESKQ98bkhIAwA5RwFKLnCANgB2PIMAVRsAGS5YXFxuRA4Aek6idVhsAQ0mZk6AQSYMAEkgsYBhAHkCsFGMWgp8eFpO7mwPD06K6vzaxFKYBAoAMXg+fL98bAoGEkgBKiDYLmYkmuhnUlwr3eDE+kCUWRyNT8uGo2A6/G4ZBqNky8BIAHdKPCABQYfDkSAeJA0WgAShqDRUJA8OLxBKJiBJ5PyswoJGodHQnEg4QADOEAKxgKK84UAFmgvIAHBxwmKOFEBQAtIwZRAMCjwbjifEcAwAA0NBgskAAVIBeDcA3TuQADq+AoAGt0tINVqdRhTQYoBFohoAMyQQCbzYAGOsAKmsGo1elLGcBQMj0fAAMxwBGIZGUJIUrHYXF4/GEonEUhk8iYSioqnUWh0+gMJigcFQqEwKcIpHIVEzwzYGG5VHR9kc3xcr1LimUlc02l00ZjpgMTDZnVo1DQnUQT0633gGE6DvwuCJu+GnTQE06i5Iy9XnTZ3HwiHU9tknROlBR98fBBck2Y3A8GgOpwBgAERgcalijJMaYdhy9AOE4I5JowsCYKQiBGFAKLMPgUj0Lg6L4PwGACPgzi0DuRCQNg3ArjQjBoHsyDYjRdEkH4sAPB4tAAGqUPAiayKMbJoNiuAUNgJDkpg9CsRyHFcbQsycQ+JBpEgRIOtIYkSVJ5KJuszCQLgsAvPifjYAwzyIDI2QMA6yDIY+RAYPMeDoKsYLUiQNDjEw2C9pAibZOiiAaOc0gvAIdkOTwbISPADyIB48iIhQib2mw9AMGepmMF4zgADTGaZWByZm+KkeRlFBR4aBEDIJAZWy+XspqGBUSZLynDZiUYAA3JAeIDl18iIA6WolWZJFkRQFEdbV9XUbRHJhRFkBsoy/DJl1g5WdIyCoasR5UdiOUgi8DAFe1VEyfYB19a1ziUeSbLbhgyABSCaF0BoRjmJBHg0J2fXIAQU1eVdzjUKD22QCQAAe94UBVfA7NF8AMPDvbqGiGGFPiJBGAAooy8DfF244baiGLw4mzXcvEdDwI4oHgVGYBGEQVC0F4nREgIYVSBQj74mFBDMB4epgSBEGQFBMEZpyCHDvIyHfR10iYZAtQrTQYOEXF+AiGIYRYo9vA5JQ4jSCgWDc2gvNXgLQvm2LGgS1LRsm7gfEi31sxUxr6FBYZPK8ryIqR7yxlEXy0f8jHd2Wz7fuixgBRoGwKE/cgBksDyvpRLHhcxJEkAFERB6mXwwe2+DEyJvARCPDD+L8Hw2S9Awf3/SaoxAxmsPg7tShQyDYtw4jyOozwAxElj7C41rXoV0R0/2iS2zz5jYBL7g8hj3VE8fZAmItThFFN79JNkxTnJli88VogOTUM1wTMUazMuYbO9bYwmZMaA8BtnTJ2B+LAex9jQAOFWzh5ByAUOWFQagpw1hSEAA=== -->\n\n<!-- internal state end -->"},"request":{"retryCount":1}},"response":{"url":"https://api.github.com/repos/AconInc/ACON-Android/issues/comments/3400683866","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 14 Oct 2025 08:27:48 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"issues=write; pull_requests=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; format=json","x-github-request-id":"3056:2F25BA:31E3FAB:DC9515C:68EE0984","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4920","x-ratelimit-reset":"1760433360","x-ratelimit-resource":"core","x-ratelimit-used":"80","x-xss-protection":"0"},"data":{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#update-an-issue-comment","status":"404"}}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments