Conversation
yurim830
approved these changes
May 12, 2025
Collaborator
yurim830
left a comment
yurim830
left a comment
There was a problem hiding this comment.
고생하셨습니다! 변수 네이밍 부분 리뷰만 확인 부탁드려용
Comment on lines
35
to
36
| // 🍇 TODO: 글모 Type 확인 | ||
| let glassMorphismView = GlassmorphismView(.buttonGlassDisabled) | ||
| let glassMorphismView = GlassmorphismView(.gradientGlass) |
Collaborator
There was a problem hiding this comment.
🐿️ 확인 됐으면 TODO 지워도 될 것 같아요!
Comment on lines
45
to
47
| static var topInsetHeight: CGFloat { | ||
| return UIApplication.shared.windows.first?.safeAreaInsets.top ?? 0 | ||
| } |
Collaborator
There was a problem hiding this comment.
🐿️ 네이밍이 조금 모호하게 느껴져서 safeAreaTopHeight 은 어떤지 제안드립니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
🚨 참고 사항
네이버 Maps 사용으로 인한 변경사항
pod repo update해주세요📸 스크린샷
슬랙 디엠으로 영상으로 보내드릴게요 !
💥 To be sure
🌰 Resolve issue