Updating to node v20 and fixing tests

[gclhub]

Upgraded nodeJS version to v20. pre-commit tests began breaking because nock is no longer compatible with the native fetch library. Switched to fetch-mock instead of nock and two pre-commit tests are still failing and need to debugged.

Sample error message:

  ● Demotion report › method: execute() › execute() - Check report generated with audit log entries

    fetch-mock: No fallback response defined for GET to https://api.github.com/orgs/test/audit-log?include=all&per_page=100&phrase=created%3A%3E%3DFri%20Mar%2019%202021%2004%3A08%3A03%20GMT-0700%20%28Pacific%20Daylight%20Time%29%20created%3A%3C%3DFri%20Mar%2019%202021%2004%3A05%3A50%20GMT-0700%20%28Pacific%20Daylight%20Time%29%20

[gclhub]

@stebje Here is my latest effort trying to get nodeJS upgraded and the pre-commit tests working. I had to use git commit --no-verify to temporarily skip the pre-commit tests so I could push the branch and create the draft PR.

The error message above is probably referencing something pretty simple, and I hope to get it working tomorrow unless you have an idea in the meantime.

[gclhub]

@stebje I changed the search query here based on the documentation https://docs.github.com/en/enterprise-cloud@latest/admin/monitoring-activity-in-your-enterprise/reviewing-audit-logs-for-your-enterprise/searching-the-audit-log-for-your-enterprise#search-based-on-time-of-action

[gclhub]

@stebje I don't know if I did this correctly, but the number of expected assertions seemed to fail when the first one was in a closure above? I wonder if something changed with scoping. I reduced the number expected here and then added a new expectation in the block above, but let me know what you think.

[gclhub]

@stebje I changed these dates back to the ISO-8601 form since the previous version was creating a more human-readable date string that seemed to break the test. Could this be related to the shift from nock to fetch-mock? Not sure if this fix is correct but it seems to get things working again.

[gclhub]

@stebje This was throwing a Javascript error that I didn't quite understand, and Copilot recommended this change. I'm thinking this might be related to the calling convention of nock vs. fetch-mock?

[gclhub]

N.B. The migration from nock to fetch-mock was required by upgrading from Node 16 to Node 20 as mentioned here nock/nock#2397

[gclhub]

I was able to update most of the dependencies but still need to chase this one down that was not solved by simply updating the indirect dependencies:

# npm audit report

path-to-regexp  2.0.0 - 3.2.0
Severity: high
path-to-regexp outputs backtracking regular expressions - https://github.com/advisories/GHSA-9wv6-86v2-598j
No fix available
node_modules/path-to-regexp
  fetch-mock  6.0.0-beta.2 - 10.0.8
  Depends on vulnerable versions of path-to-regexp
  node_modules/fetch-mock-jest/node_modules/fetch-mock
    fetch-mock-jest  *
    Depends on vulnerable versions of fetch-mock
    node_modules/fetch-mock-jest

3 high severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

[gclhub]

I was able to update most of the dependencies but still need to chase this one down that was not solved by simply updating the indirect dependencies:

# npm audit report

path-to-regexp  2.0.0 - 3.2.0
Severity: high
path-to-regexp outputs backtracking regular expressions - https://github.com/advisories/GHSA-9wv6-86v2-598j
No fix available
node_modules/path-to-regexp
  fetch-mock  6.0.0-beta.2 - 10.0.8
  Depends on vulnerable versions of path-to-regexp
  node_modules/fetch-mock-jest/node_modules/fetch-mock
    fetch-mock-jest  *
    Depends on vulnerable versions of fetch-mock
    node_modules/fetch-mock-jest

3 high severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Never mind, this was a red herring that was fixed after I ran npm prune. However, there are now a number of critical dependency fixes now required but the updated versions contain breaking changes, so that will take a little bit of effort to troubleshoot.

[stebje]

Thanks for opening the PR @gclhub ! Stretched on time today but will try to reserve some time later this afternoon/evening and get back to this asap 🙏