Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary use of pywin32 for loading Windows folder #133

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Remove unnecessary use of pywin32 for loading Windows folder #133

merged 2 commits into from
Jun 2, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 26, 2020

Another attempt at #118 cc @pradyunsg

Closes #107 (I ran into something similar)
Closes #108

It's unclear who's maintaining this so cc @zoofood @daved @rawktron @MDrakos @Naatan @autarch @jdufresne

Could we also get a release? I saw #79, indicating this library may not be getting the love it deserves. That is quite unfortunate since many projects rely on appdirs:

ofek@ozone ~\Desktop $ pypinfo --days 365 appdirs
Served from cache: False
Data processed: 638.08 GiB
Data billed: 638.08 GiB
Estimated cost: $3.12

| download_count |
| -------------- |
|     39,354,264 |

@McSinyx
Copy link

McSinyx commented Feb 26, 2020

Since you're touching these, can you also refactor the try-except to try-except-else to be more explicit?

@ofek
Copy link
Contributor Author

ofek commented Feb 26, 2020

@McSinyx Done!

@ofek
Copy link
Contributor Author

ofek commented Feb 27, 2020

Any update?

@ofek
Copy link
Contributor Author

ofek commented Mar 2, 2020

Bump

also cc @mdrohmann

@ofek
Copy link
Contributor Author

ofek commented Mar 4, 2020

Has there been any progress here?

@ofek
Copy link
Contributor Author

ofek commented Mar 11, 2020

Any news?

@pradyunsg
Copy link

Nudging on this PR for reviews/merge.

@ofek
Copy link
Contributor Author

ofek commented May 14, 2020

cc @zoofood

@ofek
Copy link
Contributor Author

ofek commented May 29, 2020

Any update?

@pradyunsg
Copy link

sigh

@zoofood
Copy link
Contributor

zoofood commented Jun 2, 2020

LGTM. Thanks for the contribution. Nice to remove pywin32. Also kudos to @pradyunsg who previously contributed as well on this.

@zoofood zoofood merged commit 23aecfc into ActiveState:master Jun 2, 2020
@ofek ofek deleted the patch-1 branch June 2, 2020 07:37
@ofek
Copy link
Contributor Author

ofek commented Jun 9, 2020

@zoofood Can this be released?

@zoofood
Copy link
Contributor

zoofood commented Jun 9, 2020

Hi @ofek, working on the next release here. Working through the backlog of changes, won't all go out in one big bang (not how I like to release items. It's coming!

@ofek
Copy link
Contributor Author

ofek commented Jun 9, 2020

Yay!!!

@ofek
Copy link
Contributor Author

ofek commented Jun 24, 2020

Soon? 🙂

@ofek
Copy link
Contributor Author

ofek commented Jul 1, 2020

?

@ofek
Copy link
Contributor Author

ofek commented Jul 10, 2020

Any update?

@seibert seibert mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use pywin32 for Windows
4 participants
@ofek @McSinyx @pradyunsg @zoofood