Work around Windows bug where arguments are not properly quoted #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naatan
commented
Jul 4, 2024
cmd/state-exec/cmd_windows.go
Outdated
Comment on lines
8
to
17
| func Command(name string, arg ...string) *exec.Cmd { | ||
| cmd := exec.Command(name, arg...) | ||
|
|
||
| // Go currently does not escape arguments properly on Windows, it account for spaces and tab characters, but not | ||
| // other characters that need escaping such as `<` and `>`. | ||
| // This can be dropped once we update to a Go version that fixes this bug: https://github.com/golang/go/issues/68313 | ||
| cmd.SysProcAttr = &syscall.SysProcAttr{CmdLine: makeCmdLine(cmd.Args)} | ||
|
|
||
| return cmd | ||
| } |
There was a problem hiding this comment.
Note this is purposely duplicating logic in osutils, because a design principle behind executors is that we avoid reusing internal libraries so as to keep the executable as lightweight as possible.
There was a problem hiding this comment.
Yeah, I've accidentally included things that blew up the exe size. Fortunately we have a test to catch it 😅
Naatan
changed the title
mitchell-as
approved these changes
Jul 8, 2024
| // For this test we don't care about the svc communication. | ||
| env := e2e.OptAppendEnv("ACTIVESTATE_CI=false") | ||
|
|
||
| inputs := []string{"a<b", "b>a", "hello world", "&whoami", "imnot|apipe", "%NotAppData%", "^NotEscaped", "(NotAGroup)"} |
There was a problem hiding this comment.
That's a nice set of test inputs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a Go bug, which was filed here: golang/go#68313, and marked as duplicate of golang/go#15566, which was first reported nearly a decade ago (!!!). So rather than wait for a fix we're just going to work around it.