Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only calling toframe with variables used in a given model #20

Closed
fscottfoti opened this issue Feb 25, 2015 · 1 comment
Closed

only calling toframe with variables used in a given model #20

fscottfoti opened this issue Feb 25, 2015 · 1 comment

Comments

@fscottfoti
Copy link
Contributor

@jiffyclub You know how in UrbanSim we only compute the variables that are actually used in the yaml specs? We will need the same thing for the csv specs. Right now it computes all the variables and in a lot of cases variables simply aren't available until later on in the model chain. No hurry as I can work around it, but wanted to make a note.
@fscottfoti
Copy link
Contributor Author

I think this is not an issue. This is different than UrbanSim where a lot of variables change after each model. In other words, households and persons don't change composition during the day, so most of the variables can be cached and left. We might compute more than we have at the beginning of the simulations but it won't cost us computation over the whole simulation (as long as we just enable caching).

bstabler added a commit that referenced this issue Aug 11, 2020
@bstabler @jpn-- @toliwaga
Tnc updates and notebooks (#18)
981627e 
* move other resources into folder since examples now part of package as well

* Add new skim lookups for the TNC bridge tolls return charges below.
- odr - origin to destination reverse
- dor - destination to origin reverse

TNC revisions:
- Update TNC bridge tolls so return charges are included
- Added ride-hail single and taxi constants for trip mode choice within ride-hail tour mode choice
- Reduced TNC wait time mean and sd slightly to in the highest density category
- Turned on origin density index constant (already used for walk, bike and walk-transit modes) for TNC single and TNC shared

* allow for a small number of stop locations within walking distance

* updated tnc ascs from tm 1.5 run

* add notebooks

* add readme for notebooks folder

* Interactive tutorial (#3)

* Add verification jupyter notebook

* add shapefile

* code review

* cleanup

* update shapefile note

Co-authored-by: Ben Stabler <bstabler@users.noreply.github.com>
Co-authored-by: bstabler <benstabler@yahoo.com>

* clean up folder setup

* finish summaries notebook

* updated getting started tutorial

* continue work on the recipe book

* estimation notebooks for larch (#19)

* notebooks for auto ownership and workplace location estimation

* minimally functional larch estimation mode notebooks

includes auto ownership, workplace location, tour mode
requires larch >= 5.3.7

* revised notebooks

uses new EDB for tour_mode_choice

* update example EDBs and estimation notebooks

* Fix tour mode choice notebook (#20)

Fill in missing values in values DataFrame

* update notebook

* update getting started notebook

* more notebook updates

* notebook for estimating school location (#21)

* create two and three zone test data, see also https://github.com/ActivitySim/activitysim/wiki/Multiple-Zone-Systems-Design

* update notebook markdown

* after merge from develop, resolve conflicts, pycodestyle, and add header to school location notebook

* small doc fix

* update tests EXPECT_TOUR_COUNT

* resolve conflict

Co-authored-by: Blake <blake.rosenthal@rsginc.com>
Co-authored-by: Jeffrey Newman <jeff@newman.me>
Co-authored-by: Jeff Doyle <toliwaga@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fscottfoti