-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some zones sometimes reopen while using shadow pricing simulation #820
Comments
The simulation-based constraint algorithm selects people to re-simulate based on the probability of Notice how the percent tolerance shows up in turning the zone on-and-off, but not in the selection of people to re-simulate. I think this is the source of the discrepancy.... In other words, I can have a 5% tolerance, with a zone that has 100 enrollment. If 103 students select that zone, the sprice is > 1 and I can choose people from the zone to re-simulate, but it is within the percent tolerance and the shadow price is -999. If the 3% probability selection just so happens to choose more than 3 people to resimulate, then the zone will open back up in the next iteration. If my logic is correct here, I see a couple ways forward:
|
I like option 2 |
I agree that option 2 seems cleaner, and consistent with the purpose of
having the tolerance setting in the first place.
Joe
…On Thu, Feb 29, 2024 at 7:06 AM Alex Bettinardi ***@***.***> wrote:
I like option 2
—
Reply to this email directly, view it on GitHub
<#820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDVIH5UHEOEGAWC2PE5NBLYV5BXJAVCNFSM6AAAAABD2XBTBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGMZTSMJSGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Describe the bug
In investigating #815, I discovered that the shadow pricing simulation algorithm sometimes re-opens zones that were previously closed.
To Reproduce
Steps to reproduce the behavior:
shadow_price_utility_adjustment
column fromtrace/school_location/i*/sample/interaction_sample/alternatives-*.csv
Expected behavior
Once the shadow price simulation algorithm closes a zone, it should stay closed. Re-opening a closed zone probably doesn't completely void the results here -- in all cases I observe, it then gets closed again on the next iteration, but it probably prolongs convergence as workers or students will certainly just re-oversubscribe that zone again.
The text was updated successfully, but these errors were encountered: