Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra debug logging when in testing mode #310

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

ShootingKing-AM
Copy link
Contributor

  • Dont filter out Rocket messages when in Debug or Trace log level
  • also fixes inverted testing condition when config

Eg logs. - https://github.com/ActivityWatch/aw-webui/actions/runs/3341509927/jobs/5532792619#step:15:16

aw-server/src/logging.rs Outdated Show resolved Hide resolved
@ErikBjare
Copy link
Member

Fixed some code duplication, ready to merge when I see CI green!

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 73.32% // Head: 73.22% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (6bd7cc1) compared to base (d6b3992).
Patch coverage: 26.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   73.32%   73.22%   -0.11%     
==========================================
  Files          45       45              
  Lines        2759     2767       +8     
==========================================
+ Hits         2023     2026       +3     
- Misses        736      741       +5     
Impacted Files Coverage Δ
aw-server/src/logging.rs 0.00% <0.00%> (ø)
aw-server/src/main.rs 0.00% <0.00%> (ø)
aw-server/src/config.rs 48.21% <80.00%> (+2.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikBjare ErikBjare merged commit 5bd70f9 into ActivityWatch:master Nov 2, 2022
@ShootingKing-AM
Copy link
Contributor Author

ShootingKing-AM commented Nov 3, 2022

Aah! I felt that there is code duplication but dunno why i didnt think about breaking the chain ^^' Thanks !

But you inverted the logging condtion :3 its better to be more verbose if its LogLevel >= Debug, hence no need to filter out any messages from modules if LogLevel >= Debug - #319

I can see that you were rushing, Sorry to call you out on a busy day :3

@ShootingKing-AM ShootingKing-AM deleted the logging branch November 3, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants