Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject: Fix broken 32-bit support #42

Closed
wants to merge 1 commit into from
Closed

pyproject: Fix broken 32-bit support #42

wants to merge 1 commit into from

Conversation

johan-bjareholt
Copy link
Member

@johan-bjareholt johan-bjareholt commented Jun 27, 2020 •
edited
Loading

@johan-bjareholt
Copy link
Member Author

@ErikBjare Why isn't travis running?
Would like the CI to try to build it on windows

ErikBjare
ErikBjare reviewed Jun 27, 2020
View reviewed changes
Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this'll work as you intended.

You've also forgotten to run poetry update after editing the pyproject.toml file.

pyproject.toml Outdated
url = "https://github.com/ActivityWatch/wheels/raw/master/pyHook-1.5.1-cp36-cp36m-win_amd64.whl",
platform = "win32", platform_machine = "x86_64"
}
pyhook = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it even valid to have two pyHook entries like this? Wouldn't they collide in the resulting TOML object?

@ErikBjare
Copy link
Member

I also have no idea why Travis isn't running. I could look into it after the weekend.

@johan-bjareholt
Copy link
Member Author

Not sure this'll work as you intended.

I'm not sure either, but I need to either build it on windows or have a functioning CI to figure that out.

@ErikBjare
Copy link
Member

ErikBjare commented Jun 29, 2020 •
edited
Loading

I was certain that I had added Github actions to this repo, and I kinda had: #39

However, that PR is stalled due to the therein mentioned issue with poetry.

Edit: I cherry-picked the commit that adds GitHub Actions onto master, if you rebase it should work now.

@johan-bjareholt johan-bjareholt force-pushed the dev/32bit-support branch 2 times, most recently from 7a02dd8 to 096a856 Compare July 5, 2020 20:33
@johan-bjareholt
Copy link
Member Author

Not able to solve without poetry fixing the following issue, closing

python-poetry/poetry#1616

@johan-bjareholt johan-bjareholt deleted the dev/32bit-support branch July 5, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikBjare ErikBjare ErikBjare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johan-bjareholt @ErikBjare