Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

feat: add ED25519 to PubKey enum #138

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 21, 2023

No description provided.

@RomarQ RomarQ requested review from godenzim and gitsimon November 21, 2023 14:35
@RomarQ RomarQ self-assigned this Nov 21, 2023
@RomarQ RomarQ force-pushed the feat/add-ed25519-pubkey branch from c303e31 to b3d285b Compare November 21, 2023 15:09
Copy link
Collaborator

@gitsimon gitsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change to the enum is maybe backwards compatible in terms of polkadotjs still able to read/write the pub_keys but could you confirm? they appear In storage entries that contain Assignments which in turn are read by processor I suppose.

@RomarQ
Copy link
Contributor Author

RomarQ commented Nov 22, 2023

Yes, it is backwards compatible. Once it gets included in the runtime, we will update the processor to include it when acknowledging the jobs.

@RomarQ RomarQ force-pushed the feat/add-ed25519-pubkey branch from 9cb592b to f6b4d83 Compare January 16, 2024 08:24
@godenzim godenzim merged commit 630ce4f into develop Jan 16, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants