This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Schedule checks (respecting max_start_delay) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change achieves that the execution count is independent of `duration` and `start_delay`
test failing because imprecise detection of last report
range() instead of normalization with overcomplex second struct
gitsimon
force-pushed
the
feat/schedule-checks
branch
from
a5f1d42 to
d9ea6a3
Compare
godenzim
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_start_delayis respected during validation onpropose_matchextrinsicsreports are checked against the scheduleScheduleoffers a helper to check for overlaps with unit testsreportasks for collaboratively stating if it's the last execution (and datastructures can be cleaned up)