Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

update gazebo_ros_pkgs to crystal #42

Merged
merged 1 commit into from
Apr 9, 2019
Merged

update gazebo_ros_pkgs to crystal #42

merged 1 commit into from
Apr 9, 2019

Conversation

YueErro
Copy link
Contributor

@YueErro YueErro commented Apr 8, 2019

Same as image common, it seems to fail under ros2.

@ibaiape
Copy link
Contributor

ibaiape commented Apr 8, 2019

+1, with current ros2 branch the compilation fails with:

--- stderr: gazebo_ros                                
/mnt/Datos/workspace/ros2_mara_latest/src/gazebo_ros_pkgs/gazebo_ros/src/node.cpp: In static member function ‘static gazebo_ros::Node::SharedPtr gazebo_ros::Node::Get(sdf::ElementPtr)’:
/mnt/Datos/workspace/ros2_mara_latest/src/gazebo_ros_pkgs/gazebo_ros/src/node.cpp:80:3: error: ‘NodeOptions’ is not a member of ‘rclcpp’
   rclcpp::NodeOptions node_options;
   ^
/mnt/Datos/workspace/ros2_mara_latest/src/gazebo_ros_pkgs/gazebo_ros/src/node.cpp:81:3: error: ‘node_options’ was not declared in this scope
   node_options.arguments(arguments);
   ^
make[2]: *** [CMakeFiles/gazebo_ros_node.dir/src/node.cpp.o] Error 1
make[1]: *** [CMakeFiles/gazebo_ros_node.dir/all] Error 2
make: *** [all] Error 2
---

@LanderU
Copy link
Contributor

LanderU commented Apr 8, 2019

Yep, you need to use crystal release.

@rkojcev rkojcev requested review from nzlz and LanderU April 9, 2019 08:16
@LanderU
Copy link
Contributor

LanderU commented Apr 9, 2019

LGTM!

@rkojcev
Copy link
Contributor

rkojcev commented Apr 9, 2019

@nzlz you mentioned this morning something about updating docker?

@LanderU
Copy link
Contributor

LanderU commented Apr 9, 2019

@nzlz you mentioned this morning something about updating docker?

Let me know what you need. I can take care of this.

@nzlz
Copy link
Contributor

nzlz commented Apr 9, 2019

Not related to this PR. But since we are changing the gazebo_ros_pkgs branch, can we start using :

  gazebo_ros_pkgs:
    type: git
    url: https://github.com/acutronicrobotics/gazebo_ros_pkgs
    version: ros2_gym-gazebo

This branch contains crystal + some extra plugins not available in the crystal branch yet.
Ill try to make a PR with the ai changes today.

@rkojcev rkojcev merged commit 5a6d50a into master Apr 9, 2019
@YueErro YueErro deleted the yue-patch-1 branch April 9, 2019 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants