Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

rename file #49

Merged
merged 1 commit into from
Apr 17, 2019
Merged

rename file #49

merged 1 commit into from
Apr 17, 2019

Conversation

YueErro
Copy link
Contributor

@YueErro YueErro commented Apr 17, 2019

Renaming the file in order not to confuse people. This is not AI related launch.

@nzlz
Copy link
Contributor

nzlz commented Apr 17, 2019

hros_cognition_mara_components Node should be removed if this is for the real robot and no gym-gazebo2 stuff. Also, are you using the robot_state_publisher for something?

@rkojcev
Copy link
Contributor

rkojcev commented Apr 17, 2019

dont merge, @nzlz review please

@nzlz
Copy link
Contributor

nzlz commented Apr 17, 2019

Last time I checked with @ahcorde I believe we talked about robot_state_publisher was not being used. Can @ahcorde @LanderU confirm this? If we are not using cognition or state publisher in the real robot, we can completely remove the mara_bringup ros package.

@nzlz nzlz requested a review from LanderU April 17, 2019 11:11
@LanderU LanderU requested a review from igorrecioh April 17, 2019 11:52
@igorrecioh
Copy link

igorrecioh commented Apr 17, 2019

AFAIK, we use this for real MARA:

roslaunch mara_bringup mara_bringup_moveit_actions.launch

Here the code of mara_bringup_moveit_actions.launch:

<?xml version="1.0"?>
<launch>

  <arg name="prefix" default="140"/>

  <param name="robot_description" command="$(find xacro)/xacro --inorder '$(find mara_description)/urdf/mara_robot_gripper_$(arg prefix).urdf.xacro'" />

  <!-- Robot state publisher -->
  <node pkg="robot_state_publisher" type="robot_state_publisher" name="robot_state_publisher">
    <param name="publish_frequency" type="double" value="50.0" />
    <param name="tf_prefix" type="string" value="" />
  </node>

  <node pkg="mara_bringup" type="follow_joints_trajectory_actions.py" name="follow_joints_individual_trajectory" args="$(find mara_bringup)/config/motors.yaml">
  </node>

  <include file="$(find mara_moveit_config)/launch/mara_moveit_planning_execution.launch">
  </include>

  <include file="$(find mara_moveit_config)/launch/moveit_rviz.launch">
    <arg name="config" default="true"/>
  </include>

</launch>

So I would say that we use robot_state_publisher. Let's wait until @ahcorde confirms it but...

@rkojcev
Copy link
Contributor

rkojcev commented Apr 17, 2019

ok then lets just rename this and leave the other part untouched.

@rkojcev rkojcev merged commit 432ba39 into master Apr 17, 2019
@LanderU LanderU deleted the naming branch April 17, 2019 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants