Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

updating readme related to ROS1/2 bridge #59

Merged
merged 5 commits into from
May 3, 2019
Merged

updating readme related to ROS1/2 bridge #59

merged 5 commits into from
May 3, 2019

Conversation

alesolano
Copy link
Contributor

No description provided.

@alesolano
Copy link
Contributor Author

don't merge yet. may be more readme updates to come

@LanderU
Copy link
Contributor

LanderU commented May 2, 2019

Are we ready to merge it?

@alesolano
Copy link
Contributor Author

wait a sec

@alesolano
Copy link
Contributor Author

not very readme but

YueErro
YueErro previously requested changes May 3, 2019
Copy link
Contributor

@YueErro YueErro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put it back? python3 works for me.

@alesolano
Copy link
Contributor Author

I prefer using python2 since it works fine from the beginning without needing to install anything additional.

If we want to change it to python3 (I don't see any advantages) we would need to add the next lines in the dependencies as mentioned here https://github.com/erlerobot/management/issues/1844#issuecomment-488585373

sudo apt install python3-pip # if not done previously for HRIM
pip3 install catkin_pkg rospkg pyyaml

Any opinions on this @rkojcev @nzlz @ahcorde ?

@rkojcev
Copy link
Contributor

rkojcev commented May 3, 2019

Lets stick to python2 for ROS 1 related matters. I do not see the advantage of having python3 in ROS 1 and installing additionally things that potentially break or remove other packages.

@rkojcev rkojcev dismissed YueErro’s stale review May 3, 2019 07:50

We should not use python3 with ROS1

@alesolano
Copy link
Contributor Author

nothing more to add to this PR from my side

@rkojcev rkojcev merged commit f745285 into master May 3, 2019
@alesolano alesolano deleted the readme branch May 3, 2019 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants